chore(mcp): add tsc build pipeline + convert small lib utilities to TypeScript (Phase 1 of #7291) - #7409
Merged
JSONbored merged 2 commits intoJul 20, 2026
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…ypeScript Adds packages/loopover-mcp/tsconfig.json and switches the package's build script from a node --check-only chain to a real tsc compile (in-place .ts -> .js emit, import paths unchanged) plus a glob-driven syntax verification pass, mirroring loopover-miner's own build pipeline. Converts the four smallest, lowest-risk lib files: cli-error.js, format-table.js, redact-local-path.js, telemetry.js. Refs JSONbored#7328
…d format-table.js tsc's printer left a trailing space at the end of renderRow's arrow-function line when a comment sat between => and its expression body in the .ts source -- caught by CI's git diff --check gate. Hoists the comment above the declaration instead; no behavior change.
JSONbored
force-pushed
the
claude/issue-7328-mcp-phase1
branch
from
July 20, 2026 07:36
1ec76d4 to
630076d
Compare
JSONbored
approved these changes
Jul 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7409 +/- ##
=======================================
Coverage 91.21% 91.22%
=======================================
Files 716 716
Lines 72789 72793 +4
Branches 20858 20881 +23
=======================================
+ Hits 66392 66402 +10
+ Misses 5355 5349 -6
Partials 1042 1042
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jul 20, 2026
jaytbarimbao-collab
added a commit
to jaytbarimbao-collab/gittensory
that referenced
this pull request
Jul 20, 2026
…Nbored#7291) Convert packages/loopover-mcp/lib/local-branch.js to real TypeScript, using the tsc build pipeline landed in Phase 1 (JSONbored#7409). Types only; runtime behavior is byte-identical (the compiled lib/local-branch.js changes only in tsc formatting and the elision of an already-dead node:path `join` import). Add unit coverage for the local scorer-preview machinery (previously untested in the .js) so the newly-typed file clears codecov/patch, and mark the handful of provably-unreachable defensive fallbacks with `v8 ignore` directives (the pattern already used across the converted packages/loopover-miner/lib TypeScript files). Remove the now-unused `@ts-expect-error package helper is plain JS` directives above the dynamic local-branch.js imports in test/unit/local-branch.test.ts and test/unit/local-scorer-adapter.test.ts, which now resolve to the typed .ts source. Closes JSONbored#7329
Closed
1 task
loopover-orb Bot
pushed a commit
that referenced
this pull request
Jul 20, 2026
…overage (#7472) The comment above the packages/loopover-mcp/lib/**/*.js coverage.include entry said lib/cli-error.js had no in-process test. That stopped being true when #7409 added test/unit/mcp-cli-error.test.ts, which imports cli-error.js in-process and exercises all three of its exports. Correct the sentence so it reflects that all five of the package's lib/ files now have in-process tests. Comment-only; no glob or behavior change. Closes #7435
Closed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/loopover-mcp/tsconfig.jsonand switches the package'sbuildscript from anode --check-only chain to a realtsccompile (in-place.ts->.jsemit, import paths unchanged), plus a glob-drivenscripts/check-syntax.mjssyntax-verification pass -- mirroringpackages/loopover-miner's own build pipeline exactly (build:tsc && build:verify).lib/files to real TypeScript:cli-error.js,format-table.js,redact-local-path.js,telemetry.js.declaration: false(no new.d.tsartifact type) and"!lib/**/*.ts"/"!scripts/check-syntax.mjs"exclusions inpackage.json'sfileskeep the npm tarball's file list byte-identical to before -- verified againsttest/unit/check-mcp-package.test.ts's allowlist.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #7328
Validation
git diff --check(againstorigin/main, matching CI'schangesjob exactly -- see Notes)npm run actionlintnpm run typechecknpm run test:coveragelocally -- 100% lines/branches/functions on all 4 converted files, including a newtest/unit/mcp-cli-error.test.tsforcli-error.js(previously untested at all) and added branch-coverage tests totest/unit/format-table.test.ts.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm audit --audit-level=moderatereports a pre-existing high-severityadm-zipadvisory (no fix available) viagithub-actionlint, inherited unchanged frommainand unrelated to this PR'spackages/loopover-mcpscope.Safety
Notes
.js.tsc's printer left a trailing space at the end offormat-table.js's compiledrenderRowline because a comment sat between=>and its expression body in the.tssource -- caught by CI'sgit diff --checkgate (bare localgit diff --checkdoesn't catch this since it only diffs uncommitted changes, not the full PR diff againstorigin/main; another contributor hit the identical tsc-printer quirk elsewhere in this repo, e.g.de94afbb8). Fixed by hoisting the comment above the declaration.format-table.test.ts,redact-local-path.test.ts,mcp-local-telemetry.test.ts) had a@ts-expect-errorsuppression for dynamically importing what was previously an untyped.jsmodule; these are now stale (TypeScript resolves the import to the new.tssource directly) and were removed.