fix(ci): switch fetch-test-timing.mjs to Codecov's test-analytics endpoint - #7403
Merged
Merged
Conversation
…point
test-results/ is deprecated -- confirmed live, running test-timing-refresh.yml
via workflow_dispatch returned a 301 pointing at test-analytics/ instead
("This endpoint has been deprecated. Please use /test-analytics/ instead.").
Verified via Codecov's own live OpenAPI schema that the replacement returns
the identical PaginatedTestrunList wrapper and Testrun field shape, so this
is a pure URL fix -- nothing else in the aggregation logic needed to change.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7403 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 716 716
Lines 72789 72789
Branches 20859 20859
=======================================
Hits 66392 66392
Misses 5355 5355
Partials 1042 1042
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/fetch-test-timing.mjs(added in the duration-aware sharding PR, #7381) called Codecov's/test-results/endpoint. You manually rantest-timing-refresh.ymlviaworkflow_dispatchand it failed immediately with a live 301:"This endpoint has been deprecated. Please use /test-analytics/ instead."— Codecov apparently deprecated it after the original research for #7381 checked their spec, or the finding was already stale by the time it shipped.Fixed by pointing at
/test-analytics/instead. Verified against Codecov's live OpenAPI schema (api.codecov.io/api/v2/schema/) that the replacement endpoint returns the identicalPaginatedTestrunListwrapper andTestrunfield shape (filename,duration_seconds,commit_sha, etc.) — a pure URL rename, so the aggregation logic in the rest of the file is untouched.Until this merges,
test-timing-refresh.ymlfails every run, socompute-test-shards.mjskeeps using its round-robin fallback (safe, already verified — just not the actual duration-weighted balancing this whole feature exists for).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnode --check scripts/fetch-test-timing.mjsCODECOV_API_TOKEN, by design) — the real end-to-end check is the next scheduled/manual run oftest-timing-refresh.ymlafter this merges.Safety
Notes
scripts/, not.github/workflows/**itself — may not need the same manual-hold treatment as the workflow-file PRs this session, but flagging since it's still CI-adjacent infrastructure.workflow_dispatchre-run oftest-timing-refresh.ymlafter this merges to confirm the fix actually works end-to-end, not just that the URL matches the deprecation notice's stated replacement.