Skip to content

feat(ui): add the self-serve signup entry surface#7402

Closed
shin-core wants to merge 1 commit into
JSONbored:mainfrom
shin-core:feat/signup-entry-4802
Closed

feat(ui): add the self-serve signup entry surface#7402
shin-core wants to merge 1 commit into
JSONbored:mainfrom
shin-core:feat/signup-entry-4802

Conversation

@shin-core

Copy link
Copy Markdown
Contributor

What

Adds the signup entry surface to the self-serve install flow — a new /signup route that is the first step (“Sign up”) of the signup → install → confirm flow described in #4802. The /install flow already describes “Sign up” as step 1 but had no dedicated page for it; this is that page.

This is a scoped slice of #4802, complementing the existing /install entry surface (#7203). It does not touch the /install files — it is a standalone top-level route.

Details

  • /signup (signup.tsx) explains the GitHub-backed account model and starts the real GitHub OAuth flow via useSession().signIn() (which redirects to /v1/auth/github/start) — the same mechanism the rest of the app authenticates with. There is no fabricated credential form: identity is GitHub’s, matching how app-shell.tsx’s signed-out state works. The primary CTA (“Continue with GitHub”) shows a starting/disabled state while sign-in is in flight and surfaces an auth error if one occurs.
  • Three explanation cards — GitHub is your identity, Scoped from the start, Straight to connecting a repo — make clear that signing up grants no repository access; that happens only at install.
  • A “Nothing is granted by signing up” safety callout links onward to /install.

Built on the shared design-system primitives (Section, Card, Callout, Eyebrow, design tokens) per the issue’s design-system boundary. Reads no secrets; fabricates no session.

Validation

  • npm run ui:typecheck, npm run ui:lint — pass.
  • New signup.test.tsx (5 tests, all passing) covers: the three account points render, the CTA calls the real signIn() (and asserts no password field is present), the starting/disabled state, the auth-error surface, and the onward /install link.
  • git diff --check clean; the diff is exactly signup.tsx, signup.test.tsx, and the routeTree.gen.ts addition of the one new route (no doc/openapi churn).

UI Evidence

/signup is a new route, so before is the app’s Not-Found state at that path and after is the new page. loopover-ui is a dark-mode-only build (theme-toggle.tsx — the toggle was removed and there is no light theme to force), so Dark is the only theme dimension; each viewport is shown below.

Viewport Before (Not Found) After (/signup)
Desktop · Dark (1280×800) Desktop · Dark · before Desktop · Dark · after
Tablet · Dark (768×1024) Tablet · Dark · before Tablet · Dark · after
Mobile · Dark (375×812) Mobile · Dark · before Mobile · Dark · after

Closes #4802

@shin-core
shin-core requested a review from JSONbored as a code owner July 20, 2026 06:36
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 20, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 20, 2026
@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - reject/close recommended

Review updated: 2026-07-20 06:42:08 UTC

3 files · 1 AI reviewer · 1 blocker · CI green · unstable

🛑 Suggested Action - Reject/Close

Review summary
This adds a new standalone `/signup` route page that explains the GitHub-backed account model and wires the real `signIn()` OAuth flow, plus the generated `routeTree.gen.ts` route registration and a focused test suite. The implementation is correct and consistent with the described `/install` pattern — no fabricated credential form, no secrets read, and the tests exercise the actual `signIn()` call, starting/error states, and the onward link. The routeTree.gen.ts diff is standard generated output from the router codegen and matches the existing pattern for other routes in the file.

Nits — 6 non-blocking
  • signup.tsx:55 the SignupPage component body is fairly long (~83 lines); consider extracting the CTA button and error banner into small subcomponents for readability, though this is consistent with similar page components elsewhere.
  • routeTree.gen.ts:95 the `as any` cast on `SignupRouteImport.update({...})` is copy-pasted from the existing codegen pattern used by every other route in this file, so it's not a new risk, just worth noting it's generated code.
  • The PR description doesn't show explicit linkage to a specific eligible open issue beyond referencing Self-serve signup & App-install flow #4802 and feat(ui): add the self-serve install-entry surface #7203 as related — worth confirming this scoped slice is maintainer-authorized before merge per repo issue-scope policy.
  • signup.test.tsx mocks `@​tanstack/react-router` broadly; consider verifying the `head()` meta/canonical config (title, og tags) is also covered by a test, since that's part of the page's contract but currently untested.
  • apps/loopover-ui/src/routes/signup.tsx: consider extracting the CTA button markup into a small shared component if a similar pattern already exists in app-shell.tsx's signed-out CTA, to avoid duplicating the disabled/loading button styling.
  • Pull request duplicates other open work — Check for an existing pull request or issue covering this change and coordinate or consolidate before continuing.

Why this is blocked

  • Linked issue overlaps another open PR — Review the related PRs before spending reviewer time on duplicate work.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. Linked issue overlaps another open PR — Review the related PRs before spending reviewer time on duplicate work.
Flagged checks (non-blocking)
  • Contributor trust — Contributor flagged for review

Decision drivers

  • ❌ Code review — 1 blocker (1 reviewer)
  • ❌ Gate result — Blocking (Repo-configured hard blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #4802
Related work ⚠️ Same linked issue: #7401 Another open PR references the same linked issue.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 75 registered-repo PR(s), 48 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor shin-core; Gittensor profile; 75 PR(s), 0 issue(s).
Improvement ✅ Minor risk: low · value: minor
Review context
  • Author: shin-core
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: TypeScript, JavaScript, Solidity, Dart, Python, CSS, PHP, Rust
  • Official Gittensor activity: 75 PR(s), 0 issue(s).
  • Related work: Items reference the same linked issue Self-serve signup & App-install flow #4802. (PR #7401)
Contributor next steps
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/signup/test desktop before /signup/test
before /signup/test
after /signup/test
after /signup/test
/signup/test mobile before /signup/test (mobile)
before /signup/test (mobile)
after /signup/test (mobile)
after /signup/test (mobile)
/signup desktop before /signup
before /signup
after /signup
after /signup
/signup mobile before /signup (mobile)
before /signup (mobile)
after /signup (mobile)
after /signup (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview
Route Before (production) After (this PR's preview)
/signup/test before /signup/test (scroll)
before /signup/test (scroll)
after /signup/test (scroll)
after /signup/test (scroll)
/signup before /signup (scroll)
before /signup (scroll)
after /signup (scroll)
after /signup (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (Linked issue overlaps another open PR; duplicate of open PR #7401). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-serve signup & App-install flow

1 participant