fix(miner): order pr-outcome map by event recency so disengagement streaks are correct (#7222)

[xfodev]

Summary

loop-reentry.js's countConsecutiveDisengagements walks backward from the end of
readPrOutcomes(...).values(), treating array order as event recency. But pr-outcome.js's
readPrOutcomes builds a Map keyed by repoFullName:prNumber, and a bare Map.set() on an
already-present key updates its value while leaving the key frozen at its first-seen iteration
position. So once the same PR gets a second, later outcome — a real case: a PR closed-without-merge,
then reopened and merged, which pr-disposition-poller.js re-polls and re-records — that entry stayed
at its old slot even though its value was now the newest. The backward walk then mis-counted a
resolved streak (e.g. reported 1 consecutive disengagement when the most recent event was actually a
merge, which should reset the streak to 0), wrongly pausing re-entry for the repo.

This applies the issue's suggested minimal fix: readPrOutcomes now deletes the key immediately
before setting it, so Map iteration order always reflects most-recently-updated last — matching
the reducer's own documented "a later event supersedes an earlier one" contract — without changing its
public Map shape. The only other consumer, orb-export.js's buildAnonymizedOrbBatch, sorts its own
output by prHash independently of input order, so it is unaffected (confirmed by its existing suite).

Closes #7222

Scope

• Conventional Commit title; focused (one module + one test); no site//CNAME/lovable; no new dependency.
• Linked a currently open issue (Closes #7222).

Validation

• git diff --check
• npm run typecheck (root — clean)
• npm run test:coverage on the changed module — 100% of the changed lines covered. New regression in
  miner-loop-reentry.test.ts: PR 1 closed, PR 2 closed, then PR 1 reopened+merged (a later event for the
  same PR number) now yields a streak of 0; it returned 1 before the fix. miner-pr-outcome and
  miner-orb-export suites pass unchanged (the other consumer is order-independent).
• npm run build:miner (node --check passes).

If any required check was skipped, explain why:

• Backend change confined to packages/loopover-miner/lib/** (one module + one test); CI runs the full suite.

Safety

• No secrets, wallets, hotkeys, coldkeys, PATs, trust scores, or private data exposed.
• Public GitHub text stays sanitized and low-noise.
• No auth/CORS/session/API/OpenAPI/MCP surface change — a pure internal ordering fix; readPrOutcomes's shape is unchanged.
• No UI change — no UI Evidence needed.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (0959d4b) to head (e3a2565).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7239   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files         704      704           
  Lines       69483    69485    +2     
  Branches    18912    18912           
=======================================
+ Hits        65187    65189    +2     
  Misses       3302     3302           
  Partials      994      994           

Flag	Coverage Δ
shard-1	43.16% <0.00%> (-0.41%)	⬇️
shard-2	37.28% <100.00%> (+0.12%)	⬆️
shard-3	32.95% <100.00%> (-0.13%)	⬇️
shard-4	32.70% <0.00%> (-1.60%)	⬇️
shard-5	32.87% <100.00%> (+0.59%)	⬆️
shard-6	46.04% <100.00%> (+0.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/loopover-miner/lib/pr-outcome.js	100.00% <100.00%> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-19 10:44:26 UTC}

2 files · 1 AI reviewer · no blockers · readiness 88/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
The fix correctly identifies that Map.set() on an existing key preserves original insertion-order position, and the delete-then-set pattern is the standard idiom to force a key to the end of iteration order, making it the right minimal fix at the source layer (pr-outcome.js) rather than patching the consumer's backward walk. The new test exercises the exact scenario described in the issue (PR 1 closed, PR 2 closed, PR 1 reopened+merged) and asserts the previously-broken behavior is fixed, which is a real regression test against the actual code path, not a fabricated one. This is a clean, well-scoped, single-purpose fix with a linked issue.

Nits — 2 non-blocking

• The comment block in pr-outcome.js:87-91 is fairly verbose for a two-line code change; the JSDoc above readPrOutcomes already documents the supersession contract, so some of this could be trimmed.
• Consider also asserting Map key order directly (e.g. `[...readPrOutcomes(...).keys()]`) in a unit test for pr-outcome.js itself, not just indirectly via countConsecutiveDisengagements, to pin down the contract at its source.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7222
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 19 registered-repo PR(s), 9 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	xfodev; Gittensor profile; 19 PR(s), 0 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff implements exactly the suggested minimal fix (delete-then-set on the key in readPrOutcomes) so Map iteration order reflects true event recency, and adds a regression test reproducing the reopen-then-merge scenario asserting the streak resets to 0.

Review context

• Author: xfodev
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, TypeScript
• Official Gittensor activity: 19 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add a concise scope and risk note.
• Then work through the remaining 1 step in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.