fix(release): auto-sync the UI's MCP version copy after every mcp publish#7135
Merged
Conversation
…lish apps/loopover-ui/src/lib/mcp-package.ts's MCP_PACKAGE_KNOWN_LATEST_VERSION (ui:version-audit, already CI-enforced) goes stale the moment mcp publishes a new version -- and since nothing updated it automatically, that showed up as a completely unrelated PR's CI turning red with zero connection to what it actually changed (confirmed live: an auto-generated release PR for a DIFFERENT package hit this exact gap twice in one session, #7115 and #7134). Can't be pre-synced in the Release PR itself: the value must never claim a version ahead of what's actually on npm (the check's own header comment already establishes this), so the earliest correct moment to update it is right after publish succeeds. Opens a small PR instead of pushing to main directly, since this repo's branch protection requires PRs.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7135 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 692 692
Lines 68851 68851
Branches 18781 18781
=======================================
Hits 64554 64554
Misses 3302 3302
Partials 995 995
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 LoopOver is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`apps/loopover-ui/src/lib/mcp-package.ts`'s `MCP_PACKAGE_KNOWN_LATEST_VERSION` (`ui:version-audit`, already CI-enforced) goes stale the moment mcp publishes a new version -- and since nothing updated it automatically, that showed up as a completely unrelated PR's CI turning red with zero connection to what it actually changed. Confirmed live: an auto-generated release PR for a DIFFERENT package hit this exact gap twice in one session (#7115 and #7134).
Can't be pre-synced in the Release PR itself: the value must never claim a version ahead of what's actually on npm (the check's own header comment already establishes this), so the earliest correct moment to update it is right after publish succeeds. Adds a `sync-ui-version-copy` job to `publish-mcp.yml` that runs after a successful publish and opens a small PR if the copy is now stale -- never pushes to main directly, since this repo's branch protection requires PRs.
Test plan