fix(release): use linked-versions to actually group engine + dependents#7123
Merged
Conversation
#7114's node-workspace merge:true was insufficient -- verified against release-please's own manifest.ts and docs/manifest-releaser.md that separate-pull-requests: true is enforced as the final PR-splitting decision regardless of what a plugin like node-workspace attempts internally, so mcp/miner's Release PRs kept landing separately from engine's even with that flag set (confirmed live: #7119/#7120/#7121 still required an unpublished @loopover/engine version each). linked-versions is release-please's actual mechanism for overriding per-component isolation for a named subset: {engine, mcp, miner} now release as one PR/commit whenever any of them needs a release, since mcp and miner both carry a real runtime dependency on engine. ui-kit has no dependency edge to any of them and is not in the group, so it keeps its fully independent cadence.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7123 +/- ##
==========================================
+ Coverage 93.75% 95.98% +2.22%
==========================================
Files 692 609 -83
Lines 68809 48153 -20656
Branches 18781 15133 -3648
==========================================
- Hits 64512 46218 -18294
+ Misses 3302 1118 -2184
+ Partials 995 817 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 17, 2026
Closed
galuis116
pushed a commit
to galuis116/gittensory
that referenced
this pull request
Jul 18, 2026
…ange buildEngineVersionDisplay's regression test hardcoded its expected fallback as the literal string "^3.0.0" -- read live from packages/loopover-miner/package.json instead, so a real release bump (confirmed live: the linked-versions release group, JSONbored#7123, bumped it to ^3.2.1 and broke this) can never silently make the test assert the wrong value again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#7114's
node-workspacemerge: truewas insufficient. Verified against release-please's ownmanifest.tsanddocs/manifest-releaser.md:separate-pull-requests: trueis enforced as the final PR-splitting decision regardless of what a plugin likenode-workspaceattempts internally -- confirmed live, mcp/miner's fresh Release PRs (#7119, #7120, #7121) still each required an unpublished@loopover/engineversion on their own separate branch, exactly the same as before #7114.linked-versionsis release-please's actual, purpose-built mechanism for overriding per-component isolation for a named subset of components (verified via its schema inschemas/config.json:type,groupName,componentsrequired;mergeoptional, defaultstrue).{engine, mcp, miner}now release as one PR/commit whenever any of them needs a release, since mcp and miner both carry a real runtimedependenciesentry on@loopover/engine.ui-kithas no dependency edge to any of them and is deliberately not in the group, so it keeps its fully independent release cadence.Test plan
release-please-config.json, matches the plugin's documented schema exactlynpm run actionlint-- clean