fix(miner): fail closed when a chat-action handler throws

[shin-core]

What

dispatchChatAction (packages/loopover-miner/lib/chat-action-dispatch.js) wraps its paramsValidator call in a try/catch — explicitly "fail closed" — but the next line, await registered.handler(request), was unguarded. A handler that throws (e.g. a network error from a governor action) would surface as an unhandled rejection instead of the module's own typed { ok, status } contract that every other failure path already returns.

This is latent today (the dashboard-chat REST endpoint that invokes it is still an open epic, #6839), but wiring it live would turn any handler throw into an unhandled rejection.

How

Wrap registered.handler(request) in try/catch, returning { ok: false, status: "handler_error", action, error } on throw — mirroring the paramsValidator catch immediately above. The distinct "handler_error" status (vs "invalid_params") lets a caller tell an execution failure apart from a validation failure. This matches the fail-closed catch pattern used by the package's other must-never-crash paths (pretooluse-hook.js:32, sentry.js:37,47).

Validation

Tests added to the existing test/unit/miner-chat-action-dispatch.test.ts: a handler throwing an Error yields handler_error with the message, and a non-Error throw is stringified — covering both sides of the instanceof Error ternary. Confirmed both fail against the unfixed code (unhandled rejection) and pass with the fix; 100% branch coverage on the file.

Closes #6989

[superagent-security]

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

[superagent-security]

Superagent found 1 security concern(s).

[superagent-security]

P2: Handler error messages returned to caller may leak sensitive internal details

Raw handler error messages are returned to the caller, risking internal detail leakage.

Log the error internally and return a generic error code instead of the raw message.

AI prompt

Check if this security scanner issue is valid. If so, understand the root cause and fix it. If appropriate, update or add tests. Keep the change focused and preserve intended behavior.

<file name="packages/loopover-miner/lib/chat-action-dispatch.js">
<violation number="1" location="packages/loopover-miner/lib/chat-action-dispatch.js:81">
<priority>P2</priority>
<title>Handler error messages returned to caller may leak sensitive internal details</title>
<evidence>The catch block for registered.handler(request) returns `error: error instanceof Error ? error.message : String(error)` directly in the typed result object. If this function is invoked from a REST endpoint, internal error details such as database connection strings, file paths, or secrets could leak to external clients.</evidence>
<recommendation>Log the full error internally and return a generic error identifier (e.g., an error code or trace ID) to the caller instead of the raw error message.</recommendation>
</violation>
</file>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.74%. Comparing base (9cddd4e) to head (a4c96fb).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7041       +/-   ##
===========================================
+ Coverage   62.24%   93.74%   +31.50%     
===========================================
  Files         692      692               
  Lines       68748    68750        +2     
  Branches    18769    18769               
===========================================
+ Hits        42793    64453    +21660     
+ Misses      23075     3302    -19773     
+ Partials     2880      995     -1885     

Flag	Coverage Δ
shard-1	43.40% <66.66%> (?)
shard-2	36.84% <0.00%> (?)
shard-3	33.15% <0.00%> (-0.21%)	⬇️
shard-4	34.40% <100.00%> (+0.49%)	⬆️
shard-5	31.66% <66.66%> (?)
shard-6	46.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/loopover-miner/lib/chat-action-dispatch.js	100.00% <100.00%> (ø)

... and 410 files with indirect coverage changes

[loopover-orb]

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 LoopOver is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing}

[JSONbored]

Outstanding superagent issue, closing.