Skip to content

feat(mcp): add CLI mirror for loopover_explain_gate_disposition#6941

Closed
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/cli-explain-gate-disposition-6740-v2
Closed

feat(mcp): add CLI mirror for loopover_explain_gate_disposition#6941
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:feat/cli-explain-gate-disposition-6740-v2

Conversation

@bohdansolovie

@bohdansolovie bohdansolovie commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Moves buildGateDispositions / GateDisposition into @loopover/engine and wires registerStdioTool("loopover_explain_gate_disposition") as a metadata-only /v1/local/branch-analysis proxy (same path as loopover_predict_gate).
  • Bumps the stdio discovery invariant from 70→71 tools.
  • Unit coverage for registration, disposition mapping, API failure, zod rejection, and predict/explain parity.

Closes #6740

Scope

  • Engine export + MCP stdio CLI mirror + tool-count pin
  • No gate policy / scoring / economics changes

Validation

  • npm run build --workspace @loopover/engine
  • npm run test -- test/unit/mcp-tool-rename-aliases.test.ts test/unit/mcp-cli-plan-scorer-tools.test.ts test/unit/mcp-explain-gate-disposition.test.ts
  • CI on this PR (draft until green; will mark ready after full validate passes)

Safety

  • Read-only metadata prediction path
  • Same public .loopover.yml boundary as loopover_predict_gate

Note

Prior attempt #6935 was auto-closed when shard 3 failed the hardcoded 70-tool count before this bump landed.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 17, 2026
@bohdansolovie
bohdansolovie marked this pull request as ready for review July 17, 2026 14:38
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 17, 2026 14:38
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 17, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-17 14:39:20 UTC

6 files · no blockers · CI pending · blocked

⏸️ Suggested Action - Manual Review

Flagged checks (non-blocking)
  • Contributor trust — Contributor flagged for review

Decision drivers

  • ✅ Code review — No blockers (No AI review summary)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6740
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (draft PR; 1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 85 registered-repo PR(s), 30 merged, 6 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 85 PR(s), 6 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Linked issue satisfaction

Addressed
The PR exports buildGateDispositions and GateDisposition from @​loopover/engine, registers registerStdioTool("loopover_explain_gate_disposition", ...) that calls the same /v1/local/branch-analysis route as loopover_predict_gate and runs buildGateDispositions locally, and adds unit tests including a parity test between the two tools, matching all stated requirements and deliverables.

Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, C++, JavaScript
  • Official Gittensor activity: 85 PR(s), 6 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (issue #6740, issue #6747)
  • Related work: Titles/paths share 7 meaningful terms. (issue #6740, issue #6741)
  • Related work: Items reference the same linked issue REST + CLI mirror for loopover_propose_action #6744. (issue #6744, PR #6939)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (d6cf892) to head (df28735).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6941   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files         685      685           
  Lines       68364    68364           
  Branches    18727    18727           
=======================================
+ Hits        61088    61090    +2     
+ Misses       5517     5511    -6     
- Partials     1759     1763    +4     
Flag Coverage Δ
shard-1 43.63% <0.00%> (ø)
shard-2 36.93% <0.00%> (+0.12%) ⬆️
shard-4 34.84% <0.00%> (+0.23%) ⬆️
shard-5 31.32% <0.00%> (-0.82%) ⬇️
shard-6 45.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-engine/src/predicted-gate.ts 98.61% <100.00%> (+0.06%) ⬆️
src/mcp/server.ts 94.23% <ø> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

Export buildGateDispositions from @loopover/engine and register the
stdio tool as a metadata-only /v1/local/branch-analysis proxy that
reshapes predictedGate into per-rule dispositions, matching the remote MCP tool.

Closes JSONbored#6740

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie marked this pull request as ready for review July 17, 2026 15:01
@bohdansolovie
bohdansolovie force-pushed the feat/cli-explain-gate-disposition-6740-v2 branch from 2722e64 to df28735 Compare July 17, 2026 15:01
@bohdansolovie
bohdansolovie marked this pull request as draft July 17, 2026 15:01
@loopover-orb loopover-orb Bot closed this Jul 17, 2026
@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown

LoopOver detected this pull request has been converted to draft 3 times — repeatedly cycling between ready and draft to solicit review feedback without a real one-shot attempt is not allowed. Please open a new pull request with the issues addressed.

@loopover-orb loopover-orb Bot added the review-evasion Gittensor contributor context label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. review-evasion Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI mirror for loopover_explain_gate_disposition

1 participant