fix(ui): use the danger/warning tokens for the extension page's demo dots#6925
Conversation
…dots The two "traffic light" dots in the extension page's faux GitHub header hand-typed oklch approximations of the --danger/--warning theme tokens instead of referencing them, unlike the sibling dot which already used bg-success. No visual change: the tokens are the same color family the hardcoded values were approximating. Closes JSONbored#6819
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-17 13:47:18 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|


Summary
The extension page's demo "traffic light" dots (a faux GitHub PR header,
apps/loopover-ui/src/routes/extension.tsx:201-202) hand-typedbg-[oklch(0.7_0.18_25)]/60andbg-[oklch(0.8_0.15_85)]/60— close approximations of the real--danger/--warningtheme tokens — instead of referencing them, unlike the sibling dot in the same block which already correctly usedbg-success/60.Replaced both with
bg-danger/60andbg-warning/60, matching the existingbg-success/60pattern. No visual change: the tokens are the same color family the hardcoded values were approximating.UI Evidence
Before (hardcoded oklch approximation) vs. after (real
--danger/--warningtokens) — visually identical, as expected:Captured via the local dev server (
npm --prefix apps/loopover-ui run dev, port 8080) against the/extensionroute'sOverlayDemocomponent, using a scripted Playwright screenshot (before =git stashreverting to the hardcoded values, after = the fix applied).Test plan
--color-danger/--color-warningare real, registered Tailwind theme colors inpackages/loopover-ui-kit/src/theme.css, already used elsewhere in this codebase (e.g. the siblingbg-successdot in the same block)grep-confirmed no other reference to the old hardcoded oklch literals remains anywhere inapps/loopover-ui/npm run ui:lint,npm run ui:typecheck— clean (0 errors)git diff --check,npm run actionlint— cleanapps/**is outside Codecov'scoverage.include(confirmed viacodecov.yml's ignore list) — no patch-coverage obligation for this UI-only change, per the issue's own Test Coverage Requirements noteCloses #6819