feat(systemd): templatize docker-prune unit for multi-host use#6730
Closed
RealDiligent wants to merge 1 commit into
Closed
feat(systemd): templatize docker-prune unit for multi-host use#6730RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:feature
Use a path-instance @.service/@.timer so WorkingDirectory and ExecStart come from %I instead of a hand-edited /opt/loopover path per host. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6730 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 682 682
Lines 68103 68103
Branches 18688 18688
=======================================
Hits 63778 63778
Misses 3347 3347
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopover-docker-pruneinto a systemd path-instance template (@.service/@.timer) so fleet hosts enableloopover-docker-prune@-opt-loopover.timer(etc.) without editingWorkingDirectory/ExecStartper machine.@unit names.Closes #4894
Test plan
%I/%icorrectly.env.example/ related systemd comments for stale non-template paths