docs(mcp): fix stale 'NOT WIRED YET' comment in telemetry.ts (#6617)#6700
Conversation
…ed#6617) The header said recordMcpToolCall is deliberately not called from the tool-dispatch path, but JSONbored#6237 (merged PR JSONbored#6358) wired it in via recordMcpToolTelemetry in src/mcp/server.ts — the single chokepoint every tools/call routes through. Comment-only correction; no runtime change. Closes JSONbored#6617
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6700 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 682 682
Lines 68112 68113 +1
Branches 18708 18708
=======================================
+ Hits 63788 63789 +1
Misses 3347 3347
Partials 977 977
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-16 20:35:54 UTC
Review summary Nits — 4 non-blocking
Flagged checks (non-blocking)
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
src/mcp/telemetry.ts's header carried a staleNOT WIRED YETnote sayingrecordMcpToolCallis deliberately not called from the tool-dispatch path.recordMcpToolTelemetryinsrc/mcp/server.ts— the single chokepoint everytools/callroutes through — which callsrecordMcpToolCalldirectly.packages/loopover-mcp/lib/telemetry.js) is untouched.Closes #6617
Test plan
test/unit/mcp-telemetry.test.ts+test/unit/mcp-server-telemetry.test.tspass unchanged (no logic touched).