Skip to content

docs(mcp): fix stale 'NOT WIRED YET' comment in telemetry.ts (#6617)#6700

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
shin-core:fix/mcp-telemetry-stale-comment-6617
Jul 17, 2026
Merged

docs(mcp): fix stale 'NOT WIRED YET' comment in telemetry.ts (#6617)#6700
JSONbored merged 1 commit into
JSONbored:mainfrom
shin-core:fix/mcp-telemetry-stale-comment-6617

Conversation

@shin-core

Copy link
Copy Markdown
Contributor

Summary

Closes #6617

Test plan

  • Comment-only diff; existing test/unit/mcp-telemetry.test.ts + test/unit/mcp-server-telemetry.test.ts pass unchanged (no logic touched).

…ed#6617)

The header said recordMcpToolCall is deliberately not called from the
tool-dispatch path, but JSONbored#6237 (merged PR JSONbored#6358) wired it in via
recordMcpToolTelemetry in src/mcp/server.ts — the single chokepoint every
tools/call routes through. Comment-only correction; no runtime change.

Closes JSONbored#6617
@shin-core
shin-core requested a review from JSONbored as a code owner July 16, 2026 19:13
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 16, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (58ab17e) to head (7dbe357).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6700   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         682      682           
  Lines       68112    68113    +1     
  Branches    18708    18708           
=======================================
+ Hits        63788    63789    +1     
  Misses       3347     3347           
  Partials      977      977           
Flag Coverage Δ
shard-1 43.90% <ø> (+<0.01%) ⬆️
shard-2 36.98% <ø> (+<0.01%) ⬆️
shard-3 32.45% <ø> (-0.01%) ⬇️
shard-4 34.24% <ø> (+<0.01%) ⬆️
shard-5 31.38% <ø> (-0.01%) ⬇️
shard-6 45.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/mcp/telemetry.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-16 20:35:54 UTC

1 file · 1 AI reviewer · no blockers · CI green · unstable

⏸️ Suggested Action - Manual Review

Review summary
This is a pure comment-fix updating a stale header note in src/mcp/telemetry.ts to correctly state that recordMcpToolCall is now wired into the tool-dispatch path via recordMcpToolTelemetry in src/mcp/server.ts. The diff makes no runtime changes — exported signatures, no-op-when-unconfigured behavior, and never-throw guarantees are untouched, consistent with the description. The comment content is plausible and specific (citing #6237/PR #6358 and the exact call site), though I cannot independently verify from this diff alone that server.ts actually calls recordMcpToolCall as described.

Nits — 4 non-blocking
Flagged checks (non-blocking)
  • Contributor trust — Contributor flagged for review

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6617
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor shin-core; Gittensor profile; 45 PR(s), 0 issue(s).
Improvement ℹ️ None detected risk: low · value: none
Review context
  • Author: shin-core
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 45 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add a concise scope and risk note.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@JSONbored
JSONbored merged commit 587c5c9 into JSONbored:main Jul 17, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP: fix stale 'NOT WIRED YET' comment in src/mcp/telemetry.ts (superseded by #6237)

2 participants