fix(notifications): enrich disposition notifications with the gate verdict#6650
Closed
nghetienhiep wants to merge 1 commit into
Closed
fix(notifications): enrich disposition notifications with the gate verdict#6650nghetienhiep wants to merge 1 commit into
nghetienhiep wants to merge 1 commit into
Conversation
…rdict The action executor's per-repo Discord/Slack notification used the plain disposition reason (action.reason) as its summary. resolveDispositionReason — built to surface the AI's recorded gate verdict for exactly this notification — was left with no call site once JSONbored#2881 migrated notifications off the pull_request.closed path and onto the executor, so the enriched, verdict-aware reason its doc comment promises never reached users. Wire resolveDispositionReason into the executor's notify path so a terminal merge/close/request_changes notification shows the latest recorded gate_decision summary for the PR, falling back to the plain disposition reason when no verdict is on record or the read fails. Closes JSONbored#6636
Owner
|
Banned. |
Contributor
| \nSuperagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6650 +/- ##
===========================================
+ Coverage 70.33% 93.64% +23.31%
===========================================
Files 680 680
Lines 68024 68025 +1
Branches 18671 18671
===========================================
+ Hits 47845 63703 +15858
+ Misses 16225 3347 -12878
+ Partials 3954 975 -2979
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(notifications): enrich disposition notifications with the gate verdict
The action executor's per-repo Discord/Slack notification used the plain
disposition reason (action.reason) as its summary. resolveDispositionReason —
built to surface the AI's recorded gate verdict for exactly this notification —
was left with no call site once #2881 migrated notifications off the
pull_request.closed path and onto the executor, so the enriched, verdict-aware
reason its doc comment promises never reached users.
Wire resolveDispositionReason into the executor's notify path so a terminal
merge/close/request_changes notification shows the latest recorded gate_decision
summary for the PR, falling back to the plain disposition reason when no verdict
is on record or the read fails.
Closes #6636