Skip to content

fix/issue 5935#5971

Closed
nghetienhiep wants to merge 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-5935
Closed

fix/issue 5935#5971
nghetienhiep wants to merge 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-5935

Conversation

@nghetienhiep

@nghetienhiep nghetienhiep commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@nghetienhiep
fix(selfhost): docker-compose.miner.yml still tags the fleet image gi…
0436f9b 
…ttensory-miner:latest

Compose's image: key and the entrypoint comment for the AMS fleet-mode
compose file were left over from the gittensory-miner rename, so
`docker compose -f docker-compose.miner.yml up -d --build` produces an
image tagged gittensory-miner:latest instead of the loopover-miner:latest
name used everywhere else (Dockerfile ENTRYPOINT, DEPLOYMENT.md, k8s/,
docs/sizing.md).

Closes JSONbored#5935
@nghetienhiep
nghetienhiep requested a review from JSONbored as a code owner July 15, 2026 04:57
@superagent-security

superagent-security Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (fe331a9) to head (0436f9b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5971   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         589      589           
  Lines       46776    46776           
  Branches    14934    14934           
=======================================
  Hits        44514    44514           
  Misses       1511     1511           
  Partials      751      751
Flag Coverage Δ
shard-1 43.49% <ø> (-0.42%) ⬇️
shard-2 35.39% <ø> (-0.82%) ⬇️
shard-3 32.77% <ø> (+0.81%) ⬆️
shard-4 31.87% <ø> (-0.10%) ⬇️
shard-5 32.42% <ø> (-0.09%) ⬇️
shard-6 44.89% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 LoopOver review result - reject/close recommended

Review updated: 2026-07-15 05:08:52 UTC

2 files · 1 AI reviewer · 1 blocker · readiness 98/100 · CI green · clean

🛑 Suggested Action - Reject/Close

Review summary
This is a small rebrand fix renaming the docker-compose image tag and comment from gittensory-miner to loopover-miner, consistent with the broader rebrand series listed in the PR. A new unit test asserts the image tag matches the expected value, which is correct and directly verifies the change.

Nits — 2 non-blocking
  • No issue link is visible in the shown diff/description tying this specific hunk to an eligible open issue beyond the general rebrand series title.
  • Confirm the Dockerfile's ENTRYPOINT is actually named `loopover-miner` (not just the comment) so the comment in docker-compose.miner.yml stays accurate.

Why this is blocked

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
📋 Copy for AI agents — paste into your coding agent 
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 52 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor nghetienhiep; Gittensor profile; 52 PR(s), 0 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: minor
Review context
  • Author: nghetienhiep
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Vue, C#, JavaScript, Python, C, C++, Go, Objective-C
  • Official Gittensor activity: 52 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (No linked issue detected). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@nghetienhiep nghetienhiep

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nghetienhiep