fix(test): stop the local gate from failing on main#5725
Merged
Conversation
Three independent, pre-existing gate breaks, none introduced by this branch -- found while chasing why release-please's PRs (#5710-5713) looked flaky under local parallel test runs, and confirmed to reproduce identically on a clean origin/main checkout: - test/unit/agent-sdk-driver.test.ts, ai-summaries.test.ts, upstream-ruleset.test.ts: each does real, non-trivial work (git subprocess round-trips, a 42-entry forbidden-word sweep, 29 sequential D1-backed scenarios) that reliably exceeds vitest's 15s default under load. Widened each to an explicit, realistic timeout instead of leaving them to flake. - test/unit/selfhost-grafana-dashboard.test.ts: 5f187c2 (#5716) fixed a real production bug -- Grafana's ${var:sqlstring} doesn't sql-quote a value that starts with $__, so the old $__all "All repos" sentinel leaked through unescaped and SQLite misparsed it as its own bind parameter, silently zeroing every "All"-filtered panel. That commit updated the dashboard JSON and two sibling test files but missed this one. - apps/gittensory-ui/public/openapi.json + 3 route/component .tsx files: 40e6cdf (#5715, the @gittensory -> @Loopover bot-mention rename) changed copy text but never regenerated the OpenAPI spec or ran prettier on the reflowed JSX text nodes, so ui:openapi:check and ui:lint both fail on main. Regenerated the spec (npm run ui:openapi) and ran eslint --fix on the affected files; both are mechanical, zero-semantic-diff outputs.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | 4c0c3c4 | Commit Preview URL Branch Preview URL |
Jul 14 2026, 08:08 AM |
…-load # Conflicts: # test/unit/selfhost-grafana-dashboard.test.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5725 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 581 581
Lines 46164 46164
Branches 14810 14810
=======================================
Hits 43886 43886
Misses 1517 1517
Partials 761 761
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
loopover-orb
Bot
added
the
gittensor:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three independent, pre-existing gate breaks on
main— none introduced by this branch. Found while investigating why release-please's #5710-#5713 looked flaky under local parallel test runs; confirmed each reproduces identically on a cleanorigin/maincheckout.agent-sdk-driver.test.ts,ai-summaries.test.ts,upstream-ruleset.test.tseach do real, non-trivial work (git subprocess round-trips, a 42-entry forbidden-word sweep, 29 sequential D1-backed scenarios) that reliably exceeds vitest's 15s default under load. Widened each to an explicit, realistic timeout.selfhost-grafana-dashboard.test.ts): 5f187c2 (fix(observability): stop using Grafana's $__ macro prefix as the SQL "All" sentinel #5716) fixed a real production bug — Grafana's${var:sqlstring}doesn't sql-quote a value starting with$__, so the old$__all"All repos" sentinel leaked through unescaped and SQLite misparsed it as its own bind parameter, silently zeroing every "All"-filtered panel. That commit updated the dashboard JSON and two sibling test files but missed this one.@gittensory→@loopoverbot-mention rename) changed copy text but never regenerated the OpenAPI spec or ran prettier on the reflowed JSX text nodes, soui:openapi:checkandui:lintboth fail onmainright now.Test plan
npm run test:cigreen end-to-end (full chain: migrations, typecheck, engine/workers/mcp/miner tests, ui lint/typecheck/test/build)npm audit --audit-level=moderatecleanopenapi.jsonvianpm run ui:openapi; confirmednpm run ui:openapi:checkpasseseslint --fixon the 3 affected.tsxfiles; confirmednpm run ui:lintpasses (0 errors)origin/mainbefore fixing, so nothing here is specific to this branch