ci(workflows): skip miner-package tests when the miner package is untouched#3775
Merged
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 317 317
Lines 32368 32368
Branches 11872 11872
=======================================
Hits 30199 30199
Misses 1537 1537
Partials 632 632 🚀 New features to boost your workflow:
|
…ouched test/unit/check-miner-package.test.ts and test/unit/miner-calibration-types.test.ts are self-contained w.r.t. root src/** (same trust boundary as the existing mcpCliHarness filter), yet ran unconditionally on every PR that touched ANY backend path -- virtually all of them, since test/** alone qualifies. Every such PR paid for a real npm pack --dry-run of packages/gittensory-miner, and a miner-only breakage (#3704's nested lib/calibration/ directory) blocked every subsequent unrelated PR's CI instead of staying contained to PRs that actually touch the package. Add a minerTestHarness paths-filter output and a SKIP_MINER_TEST_HARNESS exclude branch in the "Test with coverage" step, mirroring the existing SKIP_MCP_CLI_HARNESS pattern exactly. Push events are unaffected -- the full suite always runs on main to keep the coverage baseline solid.
JSONbored
force-pushed
the
ci/skip-miner-tests-when-untouched
branch
from
July 6, 2026 08:51
6bcbeb5 to
e1c2244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/unit/check-miner-package.test.tsandtest/unit/miner-calibration-types.test.tsare self-contained w.r.t. rootsrc/**— the same trust boundary the existingmcpCliHarnessfilter already established for the MCP CLI test cluster — but ran unconditionally on every PR that touched any backend path (virtually all of them, sincetest/**alone qualifies for thebackendfilter).npm pack --dry-runofpackages/gittensory-miner, and — as just seen live — a miner-only breakage (chore(miner): scaffold calibration module types (#2332) #3704's nestedlib/calibration/directory, fixed in fix(miner): flatten calibration module to match the flat lib/ convention #3772) blocked every subsequent unrelated PR's CI instead of staying contained to PRs that actually touch the miner package.minerTestHarnesspaths-filter output and aSKIP_MINER_TEST_HARNESSexclude branch in the "Test with coverage" step of.github/workflows/ci.yml, mirroring the existingSKIP_MCP_CLI_HARNESSpattern exactly (same filter shape: tooling/config files + the package directory + the specific test files).minerfilter — untouched by this PR.mainare unaffected: the full suite always runs there, keeping the coverage baseline solid.No issue filed — small, mechanical, self-evident CI optimization matching an existing reviewed pattern.
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not touchsite/,CNAME, or GitHub Pages.Validation
git diff --checknpm run actionlintpyyamlto confirm both the newchangesjob output and the nestedfilters:block parse correctlynpm run typecheck/npm run test:coverage— nosrc/**or test code changed, only.github/workflows/ci.yml; not run in fullnpm audit --audit-level=moderateIf any required check was skipped, explain why:
.github/workflows/ci.yml(CI configuration), no application or test source.Safety
Notes
packages/gittensory-miner/**should never be blocked or slowed by a miner-package failure.