docs(miner): clarify claim ledger is local bookkeeping only - #3638
Conversation
…d#3355) Document that miner_claims does not adjudicate duplicate winners and add regression tests for the active-only filter (JSONbored#3354). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 21:08:22 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3638 +/- ##
=======================================
Coverage 93.13% 93.13%
=======================================
Files 314 314
Lines 32002 32002
Branches 11723 11723
=======================================
Hits 29804 29804
Misses 1552 1552
Partials 646 646 🚀 New features to boost your workflow:
|
Summary
miner_claimsis a local bookkeeping primitive only — it records soft claims on this machine and does not adjudicate duplicate winners (that belongs toisDuplicateClusterWinnerByClaimin@jsonbored/gittensory-engine).Closes #3355
Closes #3354
Test plan
test/unit/miner-claim-ledger.test.ts— new Unit tests: claim-then-list, claim-then-release-then-list (released claim excluded fromlistActiveClaims), idempotent re-claim, and claims scoped correctly across two different repos. #3354 and Doc comment explicitly noting this table is a LOCAL bookkeeping primitive only and does NOT itself decide who "wins" a contested issue — that adjudication (reusingisDuplicateClusterWinnerByClaimfrom@jsonbored/gittensory-engine) is out of scope for this foundation-phase issue. #3355 casesnpm run build --workspace @jsonbored/gittensory-minerMade with Cursor