fix(signals): classify Java gRPC service stubs as generated - #3598
Conversation
Recognize grpc-java *Grpc.java service stubs in isGeneratedFile so generated-only diffs classify correctly for slop signals and the changed-files summary path-matcher dependency. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 18:34:05 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 313 313
Lines 31874 31874
Branches 11666 11666
=======================================
Hits 29705 29705
Misses 1517 1517
Partials 652 652
🚀 New features to boost your workflow:
|
Summary
Extend
isGeneratedFileto recognize grpc-java service stubs (*Grpc.java), matching the existing Swift.grpc.swiftand KotlinGrpcKt.ktconventions. Includes positive/negativeisGeneratedFile/classifyChangedFileassertions and a classification-table entry.Fixes #1957
Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.path-matchersclassification).Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesisGeneratedFile,classifyChangedFile, and the representative cases tableIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental path-matcher parity for #1957 (group changed files by
source/test/docs/config/generatedviapath-matchers). Does not deliver the summary-table renderer — only closes a generated-classification gap for grpc-java stubs.Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3595 pg-queue, #3594 enrichment exhaustiveness-drift).Made with Cursor