Skip to content

feat(engine): add ENGINE_VERSION semver pin - #3475

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-version-pin-2284
Jul 5, 2026
Merged

feat(engine): add ENGINE_VERSION semver pin#3475
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-version-pin-2284

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Closes #2284

Summary

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/engine-version.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Closes JSONbored#2284

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 08:48
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 08:53:50 UTC

4 files · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This adds a package-level ENGINE_VERSION constant, re-exports it from the engine barrel, and covers both the package.json lockstep and barrel export path with a focused unit test. The visible implementation is narrow and coherent with the version-pin portion of #2284; the predicted-gate wiring is explicitly deferred and is not part of this diff. I do not see a reachable correctness defect in the changed files.

Nits — 5 non-blocking
  • nit: packages/gittensory-engine/README.md:13 documents the consumer-facing purpose, but it should also tell release authors that package.json and src/version.ts must be bumped together so the lockstep test failure is actionable.
  • nit: test/unit/engine-version.test.ts:11 only checks equality with package.json; if this is meant to be a semver pin, add a semver-shape assertion so a bad package version cannot silently become the exported contract.
  • packages/gittensory-engine/README.md:13: add a short release-maintenance sentence such as `When bumping the engine package version, update src/version.ts in the same change; test/unit/engine-version.test.ts enforces the lockstep contract.`
  • test/unit/engine-version.test.ts:12: consider adding `expect(ENGINE_VERSION).toMatch(/^\d+\.\d+\.\d+(?:[-+][0-9A-Za-z.-]+)?$/);` if prerelease/build metadata should be accepted.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2284
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1390 registered-repo PR(s), 694 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1390 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 1390 PR(s), 49 issue(s).
  • Related work: Titles/paths share 8 meaningful terms. (issue #2278, issue #2297)
Contributor next steps
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (a979552) to head (a9ddcea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3475   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         298      299    +1     
  Lines       31203    31204    +1     
  Branches    11386    11386           
=======================================
+ Hits        29029    29030    +1     
  Misses       1518     1518           
  Partials      656      656           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/version.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 5312a56 into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(miner-foundation): version-pin gittensory-engine and wire semver into predicted-gate output

1 participant