feat(enrichment): leftover console.log / debugger analyzer - #3471
feat(enrichment): leftover console.log / debugger analyzer#3471bohdansolovie wants to merge 2 commits into
Conversation
…ugger Fixes JSONbored#2015 — flags plain debug leftovers in non-test source separately from secret-log. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid false positives on method calls like document.print(). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review result - reject/close recommendedReview updated: 2026-07-05 08:35:45 UTC
🛑 Suggested Action - Reject/Close
Review summary Blockers
Nits — 3 non-blocking
Why this is blocked
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (AI reviewers agree on a likely critical defect: review-enrichment/src/analyzers/debug-leftover.ts:13 and review-enrichment/src/analyzers/debug-leftover.ts:25 will flag Python method calls such as `obj.print('x')` as debug leftovers because `\bprint\s*\(` still matches after `.`, so change the regex to require a non-property call boundary, for example `const PRINT_RE = /(?:^|[^\w.])print\s*\(/;`, or explain why Python method calls named `print` should be blocked.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
Fixes #2015
DebugLeftoverFindingand a localdebug-leftoveranalyzer that flagsdebugger;, bareconsole.*sinks, and Pythonprint()on added non-test linescodeOnlystring stripping so literals like"console.log('hi')"are not false positivesprint()detection to.py/.pyipaths so method calls likedocument.print()are not flagged (Orb blocker on feat(enrichment): leftover console.log / debugger analyzer #3467)debugLeftoverin the analyzer registry with render/docs/metadata; skip test paths viaisTestPathreview-enrichment/test/debug-leftover.test.tscovering detection, test-file skip, cap, Python-only print, and brief renderingTest plan
cd review-enrichment && npm run build && node --test test/debug-leftover.test.ts test/analyzer-registry.test.tsvalidate-codeMade with Cursor