Skip to content

feat(engine): add hasPlanSkippedSteps and document plan DAG helpers#3470

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-plan-skipped-docs-2298
Jul 5, 2026
Merged

feat(engine): add hasPlanSkippedSteps and document plan DAG helpers#3470
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-plan-skipped-docs-2298

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Closes #2298

Summary

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-skipped.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Closes JSONbored#2298

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 08:34
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 08:41:00 UTC

4 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This adds a narrow pure predicate over the existing PlanDag shape, exports it through the engine barrel, documents it alongside the existing status helpers, and covers the empty, false, true, and barrel-export cases. The implementation matches the neighboring helper pattern and the linked issue scope is clear, so I do not see a blocking correctness problem in the visible diff.

Nits — 4 non-blocking
  • nit: test/unit/plan-skipped.test.ts imports the helper directly from src for most assertions and only checks the barrel in a separate dynamic import; if package-consumer behavior is the contract, keeping the primary import through packages/gittensory-engine/src/index would exercise the public surface more directly.
  • nit: packages/gittensory-engine/README.md lists the helper names but does not show the import path or a short usage example, which makes the new documented surface slightly less actionable for consumers.
  • In test/unit/plan-skipped.test.ts, consider importing hasPlanSkippedSteps from ../../packages/gittensory-engine/src/index in the main test path and keeping only one assertion for the barrel behavior.
  • In packages/gittensory-engine/README.md, add a compact example showing countPlanStepsByStatus and hasPlanSkippedSteps imported from @​jsonbored/gittensory-engine if the README section is intended as consumer-facing API documentation.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2298
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1390 registered-repo PR(s), 694 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1390 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, MDX, C++, HTML, Rust
  • Official Gittensor activity: 1390 PR(s), 49 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (364024c) to head (56a1ada).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3470   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         297      298    +1     
  Lines       31202    31203    +1     
  Branches    11386    11386           
=======================================
+ Hits        29028    29029    +1     
  Misses       1518     1518           
  Partials      656      656           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-skipped.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4fd8c9d into JSONbored:main Jul 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(miner-foundation): gittensory-miner and gittensory-engine README + package docs

1 participant