Skip to content

fix(engine): floor freshness for missing or invalid issue timestamps #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glorydavid03023 wants to merge 1 commit into from
Closed

fix(engine): floor freshness for missing or invalid issue timestamps #2853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/gittensory-engine/src/opportunity-freshness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,18 @@ function pickTimestamp(issue: FreshnessIssue): string | null {
return null;
}

// An open issue whose timestamp is missing or unparseable is treated as maximally STALE, not fresh: a
// malformed row must not rank ahead of genuinely fresh opportunities in the metadata ranker. This restores
// the flooring introduced with this scorer (#2806, "invalid or missing issue timestamps floor freshness
// instead of ranking malformed metadata first"). exp(-STALE_AGE_DAYS / 20) underflows to ~0, which the
// clamp raises to the 0.05 freshness floor.
const STALE_AGE_DAYS = 9999;

function issueAgeDays(value: string | null, nowMs: number): number {
if (!value) return 0;
if (!value) return STALE_AGE_DAYS;
const parsed = Date.parse(value);
if (!Number.isFinite(parsed)) return 0;
/* v8 ignore next -- pickTimestamp only ever yields a parseable string or null; kept as a defensive floor. */
if (!Number.isFinite(parsed)) return STALE_AGE_DAYS;
return Math.floor((nowMs - parsed) / 86_400_000);
}

Expand Down