Skip to content

feat(engine): add blockedLabels to miner goal spec and lane fit#2729

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
jimcody1995:feat/engine-miner-blocked-labels
Jul 3, 2026
Merged

feat(engine): add blockedLabels to miner goal spec and lane fit#2729
JSONbored merged 2 commits into
JSONbored:mainfrom
jimcody1995:feat/engine-miner-blocked-labels

Conversation

@jimcody1995

@jimcody1995 jimcody1995 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add blockedLabels to MinerGoalSpec (.gittensory-miner.yml) as the label analogue of blockedPaths
  • Parse blockedLabels in both engine parsers with the same tolerant string-list normalization as preferredLabels
  • Return lane-fit 0 when an issue carries a blocked label (case-insensitive), so discovery ranking skips those candidates

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Engine workspace tests (npm test --workspace @jsonbored/gittensory-engine) and test/unit/miner-goal-spec-parser.test.ts passed locally. Full npm run test:ci not re-run for this engine-only diff.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — engine/miner config only; no visible UI changes.

Notes

  • Path-based blocking stays in the analyze phase; this only uses labels available at discovery time.
  • Disjoint from feat/mcp-issue-slop-cli — no overlapping files, so both PRs can merge in either order without conflict.

Let maintainers declare issue labels miners must skip; lane-fit returns zero when a candidate carries a blocked label, mirroring blockedPaths for discovery metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.06%. Comparing base (57c459a) to head (5df47c9).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2729      +/-   ##
==========================================
+ Coverage   96.03%   96.06%   +0.03%     
==========================================
  Files         244      244              
  Lines       27255    27303      +48     
  Branches     9902     9919      +17     
==========================================
+ Hits        26173    26228      +55     
+ Misses        457      445      -12     
- Partials      625      630       +5     
Files with missing lines Coverage Δ
...kages/gittensory-engine/src/miner-goal-lane-fit.ts 77.27% <100.00%> (+77.27%) ⬆️
packages/gittensory-engine/src/miner-goal-spec.ts 97.46% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-03 08:50:58 UTC

10 files · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The diff coherently adds `blockedLabels` to the miner goal spec surface, defaults, both parser variants, example config, and lane-fit scoring. The runtime behavior is correct for the visible path: labels are trimmed/lowercased before matching, and a blocked-label hit returns `0` before preferred-label or discovery-policy boosts can raise the score. I do not see a reachable correctness break in the provided changed files.

Nits — 5 non-blocking
  • nit: `packages/gittensory-engine/src/miner-goal-spec.ts:115` and `packages/gittensory-engine/src/miner-goal-spec-parse.ts:33` still dedupe string-list entries case-sensitively, so `blockedLabels: ["WontFix", "wontfix"]` survives parsing even though lane-fit treats them as the same label.
  • nit: `packages/gittensory-engine/src/miner-goal-lane-fit.ts:29` recomputes normalized blocked/preferred spec labels for every candidate; if discovery ranks many issues against the same spec, consider caching normalized label sets at the caller or parser boundary.
  • In `packages/gittensory-engine/src/miner-goal-spec.ts:115` and `packages/gittensory-engine/src/miner-goal-spec-parse.ts:33`, consider de-duping label fields with the same case-insensitive key used by `computeMinerGoalLaneFit`, or document that parser de-dupe is intentionally case-preserving/exact.
  • In `packages/gittensory-engine/src/miner-goal-lane-fit.ts:29`, a `Set` for normalized issue labels would make blocked/preferred membership checks clearer and avoid repeated `includes` scans if these lists grow.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 15 registered-repo PR(s), 5 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 15 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 15 PR(s), 0 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2280, issue #2278)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2280, issue #2281)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2278, issue #2281)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 3, 2026
Add root vitest coverage for computeMinerGoalLaneFit blocked-label exclusion so codecov/patch hits the changed lines in miner-goal-lane-fit.ts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@JSONbored
JSONbored merged commit 2038e11 into JSONbored:main Jul 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants