Skip to content

feat(mcp): add issue-slop CLI for issue-quality self-checks#2728

Closed
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli
Closed

feat(mcp): add issue-slop CLI for issue-quality self-checks#2728
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli

Conversation

@jimcody1995

@jimcody1995 jimcody1995 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add gittensory-mcp issue-slop as a stdio CLI mirror of gittensory_check_issue_slop and POST /v1/lint/issue-slop
  • Support --title, --body, --body-file, and --json for agent self-checks before opening issues
  • Handle empty --body "" via normalizeOptionalStringOption so falsy empty strings are not dropped by parseOptions

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Full npm run test:ci running locally on rebased main.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — MCP CLI only; no visible UI changes.

Notes

  • Rebased onto current main (post opportunity-finder MCP merge). Advisory lint only; no source upload.
  • Disjoint from feat/engine-miner-blocked-labels — no overlapping files.

Expose POST /v1/lint/issue-slop as a stdio CLI mirror of gittensory_check_issue_slop so agents can self-check issue quality before opening work.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.01%. Comparing base (60c85c8) to head (6b8f414).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   96.09%   96.01%   -0.09%     
==========================================
  Files         243      244       +1     
  Lines       27236    27300      +64     
  Branches     9897     9919      +22     
==========================================
+ Hits        26173    26211      +38     
- Misses        438      462      +24     
- Partials      625      627       +2     
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-03 10:51:40 UTC

4 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The diff wires a new `issue-slop` subcommand through command dispatch, help text, README examples, fixture routing, and focused CLI tests. The runtime path is small and consistent with the existing `slop-risk` API-backed CLI shape, and the changed command registration is coherent. The most notable gap is that the empty-body regression test does not prove the CLI preserves an explicit empty string, because the fixture treats omitted and empty bodies identically.

Nits — 6 non-blocking
  • nit: `test/unit/mcp-cli-issue-slop.test.ts:60` does not actually verify the claimed `--body ""` preservation because `issueSlopFixture` returns the same elevated result when `body` is omitted; record the received request body or make omitted-body behavior distinct in the fixture.
  • nit: `packages/gittensory-mcp/bin/gittensory-mcp.js:1591` silently lets `--body-file` override `--body`; either document that precedence in help or reject both flags together so users do not accidentally send different text than intended.
  • nit: `packages/gittensory-mcp/bin/gittensory-mcp.js:1596` prints `payload.slopRisk` without validating the response shape; a malformed or older API response would produce `undefined` in plain output instead of a clear CLI error.
  • In `test/unit/mcp-cli-issue-slop.test.ts`, assert that the fixture received `{ body: "" }` for the empty-body case rather than only asserting the resulting finding.
  • In `printIssueSlopHelp`, mention that `--body-file` takes precedence over `--body`, or change `issueSlopCli` to throw when both are provided.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 16 registered-repo PR(s), 6 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 16 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 16 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 3, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing:

The most notable gap is that the empty-body regression test does not prove the CLI preserves an explicit empty string, because the fixture treats omitted and empty bodies identically.

@JSONbored JSONbored closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants