fix(selfhost): add a healthcheck to the ollama service - #2548
Conversation
ollama had no healthcheck block, unlike every other optional backend (qdrant, postgres, tempo, the backup-exporter). Operators following the in-file --profile ollama instructions got no compose-level signal that Ollama finished starting and is accepting API calls before the app starts using it, and there was no way to add a depends_on: ollama: condition: service_healthy gate even if desired later. Use `ollama list` as the probe (the image ships the ollama CLI but no curl/wget/nc) -- it only succeeds once the daemon is actually serving.
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-02 09:09:17 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
+ Coverage 95.95% 95.98% +0.03%
==========================================
Files 226 229 +3
Lines 25423 25814 +391
Branches 9244 9391 +147
==========================================
+ Hits 24395 24778 +383
- Misses 417 425 +8
Partials 611 611 🚀 New features to boost your workflow:
|
Summary
ollamaservice indocker-compose.ymlhad nohealthcheck:block, unlike every other optional backend (qdrant,postgres,tempo, the backup-exporter). Operators following the in-file--profile ollamainstructions got no compose-level signal that Ollama finished starting and is accepting API calls before the app starts using it, and there was no way to add adepends_on: ollama: condition: service_healthygate even if desired later.ollama list— the image ships theollamaCLI but no curl/wget/nc, andollama listonly succeeds once the daemon is actually serving; verified locally against a runningollama/ollama:0.30.10container.Closes #2504.
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally — this is adocker-compose.yml/test/**change with nosrc/**lines, so it carries no Codecov patch obligation; the new structural YAML assertion passes.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below — N/A, no UI changes.Notes