Skip to content

fix(enrichment): classify workflow paths case-insensitively in analysis-context#2525

Merged
JSONbored merged 3 commits into
JSONbored:mainfrom
kiannidev:fix/enrichment-workflow-category-case
Jul 2, 2026
Merged

fix(enrichment): classify workflow paths case-insensitively in analysis-context#2525
JSONbored merged 3 commits into
JSONbored:mainfrom
kiannidev:fix/enrichment-workflow-category-case

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • fix(enrichment): match workflow paths case-insensitively in actions-pin #2516 fixed actions-pin to scan mixed-case workflow paths, but the REES scheduler still gated actionPin on file.category === "workflow" from categorizeFile, which used case-sensitive .github/workflows/ matching.
  • PRs changing .github/Workflows/CI.YML were classified as non-workflow files, so actionPin was skipped with no_workflow even though the analyzer would scan them if invoked.
  • Normalize paths before the workflow directory check, mirroring actions-pin.ts.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • review-enrichment build + node --test test/analysis-context.test.ts — 12/12 passing (includes mixed-case workflow path regression)

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • N/A — no auth/API/UI changes.

Notes

Made with Cursor

…is-context

The actionPin scheduler gate used case-sensitive workflow path matching, so
mixed-case workflow files were skipped even after the analyzer learned to scan them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 2, 2026 07:44
@dosubot dosubot Bot added the size:XS label Jul 2, 2026
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 08:22:54 UTC

5 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The change correctly centralizes workflow path detection and uses the shared case-insensitive helper in both analysis-context categorization and the action-pin analyzer. The post-change actions-pin file no longer has its local WORKFLOW_PATH constant, so the reported stale case-sensitive matcher is not present in the provided head content. The added tests cover the scheduler gate and analysis-context category path that motivated the fix.

Nits — 5 non-blocking
  • nit: review-enrichment/src/workflow-path.ts:3 says GitHub workflow paths are case-insensitive; if the intended contract is specifically scheduler/analyzer parity for mixed-case repository paths, tighten that comment to avoid overstating platform behavior.
  • nit: review-enrichment/test/scheduler.test.ts:270 stubs actionPin, so it proves scheduler gating but not that the real action-pin analyzer still scans the same mixed-case path after the helper extraction.
  • Add a focused test around review-enrichment/src/analyzers/actions-pin.ts:39 with a mixed-case workflow path and real scanActionPins so the shared helper remains covered at the analyzer boundary too.
  • Consider exporting and directly testing isWorkflowPath from review-enrichment/src/workflow-path.ts:4 for mixed case, backslashes, and non-YAML files; that would make future category/analyzer parity regressions easier to localize.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:S; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 2219 registered-repo PR(s), 1173 merged, 39 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 2219 PR(s), 39 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 2219 PR(s), 39 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 2, 2026
…lyzer

Extract isWorkflowPath so analysis-context categorization and actionPin
use the same case-insensitive rule, with a scheduler regression test.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dosubot dosubot Bot added the lgtm label Jul 2, 2026
@JSONbored
JSONbored merged commit a401250 into JSONbored:main Jul 2, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants