Skip to content

fix(enrichment): treat uppercase action SHA pins as pinned#2466

Closed
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/actions-pin-uppercase-sha
Closed

fix(enrichment): treat uppercase action SHA pins as pinned#2466
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/actions-pin-uppercase-sha

Conversation

@bohdansolovie

@bohdansolovie bohdansolovie commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Match GitHub commit refs case-insensitively in the actions-pin analyzer.
  • Stop reporting uppercase 40-character SHA pins as mutable third-party workflow references.

Test plan

  • npm run rees:test -- test/actions-pin.test.ts

Match GitHub's case-insensitive commit refs so uppercase 40-char pins are
not reported as mutable third-party workflow references.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 2, 2026 05:10
@dosubot dosubot Bot added the size:XS label Jul 2, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 2, 2026
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 05:15:11 UTC

2 files · 1 AI reviewer · no blockers · readiness 66/100 · CI green · dirty

⏸️ Suggested Action - Manual Review

Review summary
The analyzer now treats 40-character hex action refs case-insensitively, and that is the right source predicate because scanWorkflowPins gates findings directly through FULL_SHA. The added tests cover the uppercase third-party ref path, mutable third-party refs, official-action exclusions, and the scanActionPins workflow-file filter. I do not see a reachable regression in the provided post-change files.

Nits — 3 non-blocking
  • nit: review-enrichment/test/actions-pin.test.ts:35 combines uppercase-SHA acceptance and non-workflow filtering in one empty-result assertion, which makes the failure mode less specific if it regresses later.
  • review-enrichment/test/actions-pin.test.ts:35 could split the scanActionPins case into one assertion for a workflow file pinned to an uppercase SHA and one assertion for ignoring non-workflow files, matching the tighter unit style of the earlier scanWorkflowPins tests.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 140 registered-repo PR(s), 68 merged, 11 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 140 PR(s), 11 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 140 PR(s), 11 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jul 2, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts, closing.

This branch has conflicts that must be resolved

review-enrichment/test/actions-pin.test.ts

@JSONbored JSONbored closed this Jul 2, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants