fix(queue): gate the draft-dodge close on write-permission readiness

[JSONbored]

What

The converted_to_draft draft-dodge handler (src/queue/processors.ts) calls closePullRequest() directly instead of routing through executeAgentMaintenanceActions, since the whole point is to enforce the gate verdict against the current headSha even though the PR was converted to draft. But that means this one close path never got the standard actuation pipeline's write-permission readiness check (PR_WRITE_CLASSES / resolveAgentPermissionReadiness, step 6 in executeAgentMaintenanceActions). An installation whose pull_requests: write grant was revoked or never consented would still attempt the close, get a 403 from GitHub, and have the failure silently swallowed by the existing .catch(() => undefined) — with the github_app.draft_dodge_closed audit event still recorded with outcome: "completed" as if the close actually happened. No unauthorized mutation occurs (GitHub itself rejects it), but the audit trail becomes misleading, with no signal for an operator to notice a misconfigured/under-permissioned installation.

Fix

Added a resolveAgentPermissionReadiness({ autonomy, installationPermissions }) check at the top of the draftMode === "live" branch, before the comment/close calls — mirroring executeAgentMaintenanceActions' own step 6 exactly. installationPermissions comes from a fresh getInstallation read (this handler doesn't already hold one). When not ready, records a "denied" audit outcome (same github_app.draft_dodge_closed event type, distinguishable via outcome) instead of attempting the GitHub call at all — neither the warning comment nor the close is posted, since posting a comment that promises an imminent close would be misleading if the close itself can't happen.

Longer-term routing this path through executeAgentMaintenanceActions as a proper PlannedAgentAction (which the issue also suggests, tracked jointly with the sibling live-recheck issue) would get this guard for free — out of scope here to keep this PR small and surgical.

Tests

• New test: the close is denied (not attempted — no PATCH, no comment POST) when the installation's granted permissions don't include pull_requests: write, with a "denied" audit outcome citing the missing grant.
• New test: the same denial fires when no installation row was pre-synced and the webhook payload carries no permissions (processGitHubWebhook's own unconditional upsertInstallation(env, payload) auto-creates a bare record from the payload, which has no explicit write grant either).
• All 3 pre-existing draft-dodge tests (success path, global-freeze no-op, dry-run) continue to pass unchanged.
• npx tsc --noEmit clean.
• Scoped: full queue.test.ts — 204 passed. agent-execution.test.ts (the module the new import comes from) — 11 passed.
• Diff-range coverage-gap check on src/queue/processors.ts: fully covered — a couple of genuinely-defensive fallbacks (a getInstallation read failure, a null-author edge case) are marked /* v8 ignore next */, mirroring the identical established convention already used twice in this same function for the same shapes of fallback.
• Full unsharded npm run test:coverage: 5602 passed, 4 skipped (pre-existing/unrelated), 0 failed.
• npm audit --audit-level=moderate: 0 vulnerabilities.

Advances #1936. Closes #2134.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.89%. Comparing base (22ec2e4) to head (1a474eb).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2391   +/-   ##
=======================================
  Coverage   95.88%   95.89%           
=======================================
  Files         224      224           
  Lines       25158    25162    +4     
  Branches     9150     9151    +1     
=======================================
+ Hits        24124    24128    +4     
  Misses        421      421           
  Partials      613      613           

Files with missing lines	Coverage Δ
src/queue/processors.ts	91.54% <100.00%> (+0.01%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-01 23:43:20 UTC}

2 files · 1 AI reviewer · no blockers · readiness 75/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review

Review summary
The change adds a permission-readiness gate to the draft-dodge live close path before the freshness check, denying and auditing without posting a comment or closing when PR write permission is unavailable. That matches the standard actuation pipeline behavior for this bypass path, and the new tests cover denied permissions, missing stored permissions, and transient installation-read failure. The existing freshness guard and close/comment sequence are preserved under the ready branch.

Nits — 7 non-blocking

• nit: src/queue/processors.ts:3779 has a very large explanatory comment that repeats the PR narrative; trimming it to the permission guard and retry rationale would keep this hot-path branch easier to scan.
• nit: src/queue/processors.ts:3810 records every non-ready result as "pull_requests: write not granted"; include the readiness value in metadata so future non-ready states stay diagnosable.
• nit: test/unit/queue.test.ts:11798 duplicates the same fetch stub and setup pattern across the new cases; a small helper would make the regression intent easier to maintain.
• Add `permissionReadiness: draftDodgePermissionReadiness` to the denied audit metadata in src/queue/processors.ts:3820.
• Extract a local draft-dodge test setup helper in test/unit/queue.test.ts:11798 that takes installation permissions and optional `getInstallation` behavior.
• PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2134
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (size label size:L; 1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 65 registered-repo PR(s), 55 merged, 572 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 65 PR(s), 572 issue(s).
Gate result	⚠️ Not blocking	Advisory; not blocking this PR.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 65 PR(s), 572 issue(s).
• Related work: Items reference the same linked issue fix(queue): draft-dodge close bypasses the standard actuation pipeline guards #2134. (issue #2134)
• Related work: Open PR work references issue fix(queue): draft-dodge close bypasses the standard actuation pipeline guards #2134. (issue #2134)
• Related work: Items reference the same linked issue fix(github): webhook deliveries for the same PR have no per-PR mutual exclusion #2135. (issue #2135, PR #2399)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Review top overlaps.
• Add a concise scope and risk note.
• Triage stale or unlinked PRs.
• No action.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	40efc5a	Commit Preview URL Branch Preview URL	Jul 01 2026, 11:26 PM