fix(config): honor settings.commandAuthorization in .gittensory.yml

[JSONbored]

What

.gittensory.yml.example documented settings.commandAuthorization as settable config-as-code, but FocusManifestSettings never included the field and parseSettingsOverride never read it — it was silently dropped, no warning, nothing. The field only actually took effect via the dashboard/API route (DB-persisted). This fails toward the safe side (DB/default policy silently continues), but it's a real parity gap against this repo's own .gittensory.yml > DB > defaults convention, and it's security-relevant: a maintainer restricting who can invoke /gate-override via yml would believe the restriction was live when it silently wasn't.

Fix

• Added commandAuthorization to the Pick<RepositorySettings, ...> union in FocusManifestSettings (src/signals/focus-manifest.ts).
• Wired settings.commandAuthorization into parseSettingsOverride using the existing normalizeCommandAuthorizationPolicy (src/settings/command-authorization.ts), folding its warnings into the manifest's warnings output. The normalizer always fills any unset/invalid field from DEFAULT_COMMAND_AUTHORIZATION_POLICY — the same secure default used when the DB has none — so once the key is present in yml it always yields a complete, safe policy, mirroring how settings.autoMaintain already works ("declares the full policy, defaults fill any unset field").
• resolveEffectiveSettings's existing {...dbSettings, ...manifest.settings} spread needed no change — once out.commandAuthorization is set, it wholesale-overlays the DB value the same way every other settings field does; leaving the yml key unset leaves it untouched (DB stays authoritative).
• Updated .gittensory.yml.example's doc comment for the field with a concrete example and a note on the invalid-shape fallback behavior.
• settingsOverrideToJson (the cache round-trip serializer) needed no change — it's a generic spread of whatever's on FocusManifestSettings.

Tests

• New test: valid settings.commandAuthorization parses, overlays a DB-stored policy via resolveEffectiveSettings, and an unset key leaves the DB policy untouched (never resets to defaults).
• New test: an invalid top-level shape (e.g. a string) falls back to the secure built-in default with a visible warning; a spoofable role on a maintainer-only command (e.g. pr_author on gate-override) is clamped back to the default for that command specifically, with its own warning — the maintainer-only invariant survives a partially-valid override.
• npx tsc --noEmit clean.
• Scoped: focus-manifest.test.ts — 138 passed.
• Regression sweep: all 16 other files importing src/signals/focus-manifest.ts — 373 passed.
• Diff-range coverage-gap check on src/signals/focus-manifest.ts: fully covered.
• Full unsharded npm run test:coverage: 5602 passed, 4 skipped (pre-existing/unrelated), 0 failed.
• npm audit --audit-level=moderate: 0 vulnerabilities.

Advances #1936. Closes #2268.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-01 22:55:11 UTC}

3 files · 1 AI reviewer · no blockers · readiness 75/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

Review summary
The change wires `settings.commandAuthorization` into the focus-manifest settings path and deliberately preserves DB policy when the YAML value is not a mapping, which matches the documented overlay behavior and avoids replacing a stricter stored policy with defaults. The tests cover the main reachable paths: valid override, unset inheritance, invalid top-level shapes, and normalizer warnings for invalid nested values. I do not see a correctness break in the visible diff.

Nits — 5 non-blocking

• nit: `src/signals/focus-manifest.ts:643` carries a long policy explanation inline; consider trimming it to the top-level-shape distinction and leaving the full rationale in the test or issue for readability.
• nit: `test/unit/focus-manifest.test.ts:1144` does not explicitly assert the cache round-trip through `settingsOverrideToJson`; adding one assertion would lock down the claim that the generic serializer preserves this newly added settings field.
• Add a focused `settingsOverrideToJson` assertion in `test/unit/focus-manifest.test.ts` for a parsed `commandAuthorization` policy so future serializer narrowing cannot silently drop it.
• Shorten the parser comment in `src/signals/focus-manifest.ts` to the actionable invariant: object values are normalized and non-object values warn without setting `out.commandAuthorization`.
• PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2268
Related work	⚠️ 2 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (size label size:M; 1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 65 registered-repo PR(s), 55 merged, 572 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 65 PR(s), 572 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 65 PR(s), 572 issue(s).
• Related work: Items reference the same linked issue fix(config): settings.commandAuthorization is documented as config-as-code but silently ignored by the parser #2268. (issue #2268)
• Related work: Open PR work references issue fix(config): settings.commandAuthorization is documented as config-as-code but silently ignored by the parser #2268. (issue #2268)

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Review top overlaps.
• Add a concise scope and risk note.
• Triage stale or unlinked PRs.
• No action.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.88%. Comparing base (76e9baa) to head (dce7d9a).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         224      224           
  Lines       25136    25142    +6     
  Branches     9139     9141    +2     
=======================================
+ Hits        24102    24108    +6     
  Misses        421      421           
  Partials      613      613           

Files with missing lines	Coverage Δ
src/signals/focus-manifest.ts	99.19% <100.00%> (+<0.01%)	⬆️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.