Skip to content

test(utils): cover empty JSON input and blank error messages #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 2, 2026
Merged

test(utils): cover empty JSON input and blank error messages #2375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion test/unit/json-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
import { describe, expect, it } from "vitest";
import { errorMessage, jsonString, normalizeRepoFullName, parseJson, repoParts, strippedErrorMessage } from "../../src/utils/json";
import { errorMessage, jsonString, normalizeRepoFullName, nowIso, parseJson, repoParts, strippedErrorMessage } from "../../src/utils/json";

describe("JSON and string utility helpers", () => {
it("keeps JSON parsing and stringification fallbacks explicit", () => {
expect(parseJson<{ ok: boolean }>('{"ok":true}', { ok: false })).toEqual({ ok: true });
expect(parseJson("{bad-json", { ok: false })).toEqual({ ok: false });
expect(parseJson(null, { ok: false })).toEqual({ ok: false });
expect(parseJson("", { ok: false })).toEqual({ ok: false });
expect(parseJson(undefined, { ok: false })).toEqual({ ok: false });
expect(jsonString(undefined)).toBe("null");
expect(jsonString({ ok: true })).toBe('{"ok":true}');
});

it("emits ISO timestamps and empty error fallbacks", () => {
expect(nowIso()).toMatch(/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z$/);
expect(errorMessage(new Error(""))).toBe("unknown error");
});

it("normalizes repo names and error messages without leaking arbitrary thrown values", () => {
expect(normalizeRepoFullName(" JSONbored/gittensory ")).toBe("JSONbored/gittensory");
expect(repoParts("JSONbored/gittensory")).toEqual({ owner: "JSONbored", name: "gittensory" });
Expand Down