Skip to content

fix(enrichment): accept full Go module path punctuation in dependency scan #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 2 commits into from
Jul 1, 2026
Merged

fix(enrichment): accept full Go module path punctuation in dependency scan #2121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6797cea
fix(enrichment): accept full Go module path punctuation in dependency…
real-venus Jun 30, 2026
412ad21
Merge branch 'main' into fix/dependency-scan-go-module-path-chars
JSONbored Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion review-enrichment/src/analyzers/dependency-scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ const NPM_VERSION_PREFIX_RE = /^[\^~>=<\s]+/;
// stopped at `[` silently dropped every pinned-with-extras dependency from the CVE scan.
const PYPI_RE =
/^([A-Za-z0-9._-]+)(?:\[[A-Za-z0-9._,\s-]+\])?\s*==\s*([0-9][^\s;]*)/;
const GO_RE = /^([a-z0-9.\/-]+)\s+v([0-9][^\s]*)/;
// Go module paths are case-sensitive and the element grammar admits A-Z plus the full
// punctuation set Go allows (`. _ ~ -`, per golang.org/x/mod/module modPathOK), not just `.`/`-`.
// A narrower class silently drops uppercase or `_`/`~` paths (github.com/BurntSushi/toml,
// github.com/foo_bar/baz, golang.org/x/~exp) from every dependency-fed scanner (CVE, license,
// provenance, native-build). The class stays strictly more permissive, so lowercase paths are
// unaffected, and the case-sensitive name is preserved verbatim for the OSV lookup.
const GO_RE = /^([A-Za-z0-9._~\/-]+)\s+v([0-9][^\s]*)/;

function parseLine(
manifest: string,
Expand Down
14 changes: 14 additions & 0 deletions review-enrichment/test/enrichment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,20 @@ test("extractDependencyChanges: PyPI exact pins with PEP 508 extras are parsed u
assert.equal(byPkg.celery.to, "5.4.0");
});

test("extractDependencyChanges: Go paths with uppercase and `_`/`~` punctuation are parsed", () => {
// Go module paths are case-sensitive and admit the full `. _ ~ -` punctuation set; a narrower
// path class would silently drop these deps from the OSV scan. Names are preserved verbatim.
const changes = extractDependencyChanges([
{ path: "go.mod", patch: "+\tgithub.com/BurntSushi/toml v1.4.0" },
{ path: "go.mod", patch: "+\tgithub.com/foo_bar/baz v0.9.1" },
{ path: "go.mod", patch: "+\texample.com/x/~exp v1.0.0" },
]);
const byPkg = Object.fromEntries(changes.map((c) => [c.package, c]));
assert.equal(byPkg["github.com/BurntSushi/toml"].to, "1.4.0");
assert.equal(byPkg["github.com/foo_bar/baz"].to, "0.9.1");
assert.equal(byPkg["example.com/x/~exp"].to, "1.0.0");
});

test("queryOsv: maps vulns; severity from database_specific; fixedIn from affected; [] on non-ok", async () => {
const cves = await queryOsv(
"npm",
Expand Down