fix(migrations): grandfather the shipped 0090 duplicate#2532
Closed
JSONbored wants to merge 2 commits into
Closed
Conversation
0090_contributor_cap_label.sql (#2479) and 0090_pull_request_detail_sync_head_sha.sql (#2527) both merged to main with the same migration number. Both are bare ADD COLUMN statements that are already applied in production, so renumbering either now would make wrangler try to re-apply it and error the deploy — the same non-idempotent-rename hazard already documented for the 0015/0017/0074 grandfathered pairs. Add 0090 to KNOWN_DUPLICATES so db:migrations:check passes again for every PR that touches src/**, which currently fails the required validate check on all of them regardless of whether they touch migrations/.
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2532 +/- ##
==========================================
+ Coverage 95.95% 95.96% +0.01%
==========================================
Files 226 228 +2
Lines 25391 25702 +311
Branches 9234 9346 +112
==========================================
+ Hits 24363 24666 +303
- Misses 417 425 +8
Partials 611 611 🚀 New features to boost your workflow:
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0090_contributor_cap_label.sql(feat(agent-actions): auto-close a contributor's PR over the open-PR cap (#2270) #2479) and0090_pull_request_detail_sync_head_sha.sql(fix(selfhost): cap historical PR file hydration and cache by head SHA #2527) both merged tomainwith the same migration number, sonpm run db:migrations:checkcurrently fails onmainitself — and therefore fails the requiredvalidatecheck on every PR that touchessrc/**(thebackendpath filter), not just migration PRs.ALTER TABLE ... ADD COLUMNstatements already applied in production, so renumbering either now would make wrangler (and the self-host migrator) try to re-apply an already-shipped, non-idempotent migration and error the deploy. Per the script's own documented policy for this exact situation (see the0015/0017/0074precedents), the fix is to grandfather0090intoKNOWN_DUPLICATES, not rename either file.No issue filed for this — it's a small, self-evident infra fix blocking CI for unrelated PRs, following the exact precedent already established in
scripts/check-migrations.mjsfor prior duplicate collisions.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;scripts/**andtest/**carry no Codecov patch obligation, but the affected test (test/unit/check-migrations-script.test.ts) was updated and passes.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below with JPG/JPEG or PNG screenshots — N/A, no UI changes.Notes
main-breaking migration numbering collision discovered while running the local gate for that batch.