feat(scoring): surface tied-leverage disclosure in score breakdown#2362
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 04:19:47 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 224 224
Lines 24996 24998 +2
Branches 9091 9092 +1
=======================================
+ Hits 23954 23956 +2
Misses 428 428
Partials 614 614
🚀 New features to boost your workflow:
|
11c400c to
6159627
Compare
6159627 to
c392c16
Compare
ScoreBreakdownLever gains an optional tiedLeverageComponents field; pickHighestLeverage now collects every component that ties for the top leverageScore instead of silently returning only one. Covers three paths: no tie (singleton result), blocked tie (multiple blocked levers at same score), and reduced tie (multiple reduced levers at same score).
- Creates scenario where openPrMultiplier and openIssueMultiplier both block at leverageScore 100 - Asserts alphabetical winner (openIssueMultiplier) and tied component (openPrMultiplier) - Asserts reason includes tie disclosure - Adds no-tie test asserting empty array and no tie clause in reason
c392c16 to
4d9b9d2
Compare
Summary
Replaces #1982 (cannot reopen after force-push per GitHub policy).
What changed:
Rationale: When two scoring levers tie for highest leverageScore, the breakdown silently showed only one. This disclosure lets contributors see all tied levers so they can prioritize which to fix first.
Files changed:
Validation:
Linked issue: Closes #2142 (spawned from the tied-leverage gap identified in that issue).