Skip to content

feat(enrichment): forward PR body to REES enrichment request#1862

Closed
kiannidev wants to merge 1 commit into
JSONbored:mainfrom
kiannidev:feat/enrichment-forward-pr-body
Closed

feat(enrichment): forward PR body to REES enrichment request#1862
kiannidev wants to merge 1 commit into
JSONbored:mainfrom
kiannidev:feat/enrichment-forward-pr-body

Conversation

@kiannidev

@kiannidev kiannidev commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Forward pr.body through runAiReviewForAdvisorybuildReviewEnrichment so REES history can parse Fixes #N from the PR description.

Issue

Action: Open upstream issue feat(enrichment): forward PR body to REES enrichment request and link Fixes #… before gate review.

Validation

npx vitest run test/unit/enrichment-wire.test.ts test/unit/enrichment-wiring.test.ts -t "body|FLAG-ON"

Test plan

  • Non-empty PR body appears in REES POST
  • Missing body omits the field
  • Processor wiring test covers advisory → enrichment path

Pass pr.body through buildReviewEnrichment so the REES history analyzer
can parse Fixes #N references from the PR description.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from JSONbored as a code owner June 30, 2026 10:43
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 30, 2026
@gittensory-orb

gittensory-orb Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-06-30 10:49:16 UTC

4 files · 1 AI reviewer · no blockers · readiness 50/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review

Review summary
The diff cleanly threads an optional PR description from `runAiReviewForAdvisory` into `buildReviewEnrichment` and includes it in the REES POST only when present, which matches the stated goal of letting downstream history parsing see `Fixes #N`. The changed tests cover the advisory processor path and the positive request payload, and the omission behavior is consistent with the existing optional-field style used for `githubToken`. The only notable gap is that the new “empty body” test exercises an absent body, not an explicit empty string.

Nits — 4 non-blocking
  • nit: `test/unit/enrichment-wire.test.ts` names the new case as empty-body coverage, but it never passes `body: ""`; rename it to missing-body coverage or pass the explicit empty string to match the claim.
  • In `test/unit/enrichment-wire.test.ts`, either change the new test input to `{ ...input, body: "", author: "alice" }` or rename the test to `omits body from the REES POST when the PR body is missing` so the test documents the exact branch it covers.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR; address the blocker before review.
Contributor workload ✅ 10/10 Author activity: 3134 registered-repo PR(s), 1794 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 3134 PR(s), 49 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Review context
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Fix the blocker.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue was closed as not planned, and review blockers:

The only notable gap is that the new “empty body” test exercises an absent body, not an explicit empty string.

@JSONbored JSONbored closed this Jun 30, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. gittensor Gittensor contributor context size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants