Skip to content

Add tests proving admin can resolve disputes#475

Open
ositaemmanuel653-netizen wants to merge 6 commits into
JSE-ORG:mainfrom
ositaemmanuel653-netizen:add-admin-resolve-dispute-tests
Open

Add tests proving admin can resolve disputes#475
ositaemmanuel653-netizen wants to merge 6 commits into
JSE-ORG:mainfrom
ositaemmanuel653-netizen:add-admin-resolve-dispute-tests

Conversation

@ositaemmanuel653-netizen

@ositaemmanuel653-netizen ositaemmanuel653-netizen commented Jun 24, 2026

Copy link
Copy Markdown

Close #454


  • Add test_admin_resolve_dispute.rs with two new tests
  • Admin resolves dispute with Release (vendor wins) and escrow transitions to Completed
  • Admin resolves dispute with Refund (buyer wins) and escrow transitions to Refunded
  • Verify correct payouts and arbitration fee handling in both scenarios
  • Register new test module in lib.rs

Pull Request Checklist

Thank you for contributing! Please review the following checklist to ensure your PR is ready for review.

Summary

  • Provide a clear and concise description of the changes.
  • Link to any related issues using Fixes #issue or Related to #issue.

Testing

  • All new code is covered by unit tests where applicable.
  • Existing tests pass locally (cargo test).
  • Added tests for edge cases and error conditions.
  • Updated any integration tests if necessary.

Documentation

  • Updated README.md if changes affect users.
  • Updated docstrings/comments for new/modified functions.
  • Added examples or updated existing examples if applicable.

Code Quality

  • Follows the project's coding style and conventions.
  • No commented-out code or debug statements left in the codebase.
  • Variables and functions are named descriptively.
  • Code is properly formatted (cargo fmt).
  • No new clippy warnings (cargo clippy).

Breaking Changes

  • If this PR introduces breaking changes, describe them and provide migration steps.
  • Updated version in Cargo.toml if appropriate (following semver).

Additional Notes

  • Any other relevant information for reviewers.

Please ensure all checkboxes are checked before requesting a review.

- Add test_admin_resolve_dispute.rs with two new tests
- Admin resolves dispute with Release (vendor wins) and escrow transitions to Completed
- Admin resolves dispute with Refund (buyer wins) and escrow transitions to Refunded
- Verify correct payouts and arbitration fee handling in both scenarios
- Register new test module in lib.rs
@ositaemmanuel653-netizen

Copy link
Copy Markdown
Author

Close #454

@drips-wave

drips-wave Bot commented Jun 24, 2026

Copy link
Copy Markdown

@ositaemmanuel653-netizen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@JSE19

JSE19 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

CI/Test and CI/Check are failing, please cross check the failed checks and fix them

@JSE19

JSE19 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

👋 main has been fixed — \ und_escrow\ and
aise_dispute\ are restored and clippy is clean. Could you rebase your branch on the latest main so CI re-runs? \git rebase main\ then force-push.

@ositaemmanuel653-netizen ositaemmanuel653-netizen force-pushed the add-admin-resolve-dispute-tests branch from b844f94 to f3e22c6 Compare June 25, 2026 20:08
@ositaemmanuel653-netizen

Copy link
Copy Markdown
Author

Done

@ositaemmanuel653-netizen

Copy link
Copy Markdown
Author

Hello maintainer.check issue,dispute has been resolved.

@ositaemmanuel653-netizen

Copy link
Copy Markdown
Author

Hello maintainer,please am still waiting for your final reviews as time is of the essence.

@ositaemmanuel653-netizen

Copy link
Copy Markdown
Author

@JSE19 Please check and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for resolve_dispute admin path

2 participants