fix(telegram): truthful delivery confirmation — save and notify on injection failure#242
Open
brianjones-v4n wants to merge 1 commit into
Open
Conversation
…jection failure Today the Telegram→session route sends "✓ Delivered" unconditionally after calling SessionManager.injectTelegramMessage. When injection fails (returns false), the user gets a misleading confirmation while their message is silently dropped. This: - checks the return value of injectTelegramMessage - on failure, saves the failed message text under <stateDir>/state/failed-messages/ (not /tmp — keeps failed messages out of world-readable temp space) - on failure, sends a user-visible warning instead of the success confirmation, telling the user the message did not reach the session and has been saved Matches the secure-state-dir pattern established in PR JKHeadley#32. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@brianjones-v4n is attempting to deploy a commit to the sagemind Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Telegram→session route currently sends `✓ Delivered` unconditionally after calling `SessionManager.injectTelegramMessage`. When injection fails (returns `false`), the user gets a misleading success confirmation while their message is silently dropped.
This:
Matches the secure-state-dir pattern established in PR #32.
Test plan
🤖 Generated with Claude Code