CMP-411 macro kleam - #240
Open
realxinzhao wants to merge 6 commits into
Open
Conversation
pralitp
requested changes
Jul 21, 2026
pralitp
left a comment
pralitp
left a comment
Contributor
There was a problem hiding this comment.
Overall great job and thanks for being so thorough.
I think a couple of minor things but noted in several places:
- We should try to let the documentation be descriptive of the model as it exists and not try to make it incremental. As such there were a number of places I flagged to try to avoid creating distinction between KLEM and KLEAM -- and in general avoid KLEAM so that we don't have to go back later and change them all when the next iteration of Macro comes along.
- Minor thing but the way it renders links to assumptions files enclosed in backticks makes it less clear that they are links so I think maybe just remove those backticks. I flagged this in several places.
…ng KLEAM and ensure links render properly without backticks
mwisepnnl
reviewed
Jul 24, 2026
mwisepnnl
left a comment
mwisepnnl
left a comment
There was a problem hiding this comment.
lots or great stuff including catching up on previous things!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation for CMP410 & 411.