Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-67] feat: 디자인 시스템 수정 및 추가사항 반영 (색상, 아이콘, Input) #42

Merged
merged 14 commits into from
Jan 15, 2025

refactor: 아이콘 토글 로직 리팩토링

2a4406f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[TASK-67] feat: 디자인 시스템 수정 및 추가사항 반영 (색상, 아이콘, Input) #42

refactor: 아이콘 토글 로직 리팩토링
2a4406f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Qodana for JS completed Jan 14, 2025 in 0s

25 new problems found by Qodana for JS

Qodana for JS

25 new problems were found

Inspection name Severity Problems
Unused local symbol 🔶 Warning 5
Import can be shortened 🔶 Warning 3
Exception used for local control-flow 🔶 Warning 2
Constant conditional expression 🔶 Warning 1
Pointless statement or boolean expression 🔶 Warning 1
Redundant local variable 🔶 Warning 1
Missing await for an async function call ◽️ Notice 6
Result of method call returning a promise is ignored ◽️ Notice 3
Duplicated code fragment ◽️ Notice 1
Deprecated symbol used ◽️ Notice 1
Vulnerable declared dependency ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check failure on line 1 in src/components/Icon/icons/MoreVertical.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

ESLint

ESLint: Install the 'eslint' package

Check failure on line 1 in src/components/Input/BasicInput.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

ESLint

ESLint: Install the 'eslint' package

Check warning on line 6 in src/components/Navbar/NavbarNoticeDetail/NoticeUnit.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Constant conditional expression

`false ? 'bg-gray-800' : 'bg-gray-900 text-gray-500'` can be simplified

Check notice on line 23 in src/apis/follow/deleteFollow.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Duplicated code fragment

Duplicated code

Check notice on line 43 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check notice on line 134 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check notice on line 131 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check notice on line 63 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check notice on line 89 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check notice on line 50 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Missing await for an async function call

Missing await for an async function call

Check warning on line 1 in src/types/buttons/SquareButtonLProps.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Import can be shortened

Import can be shortened

Check warning on line 1 in src/types/buttons/OvalButtonProps.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Import can be shortened

Import can be shortened

Check warning on line 1 in src/types/buttons/FollowButtonProps.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Import can be shortened

Import can be shortened

Check warning on line 19 in src/apis/follow/postFollow.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Exception used for local control-flow

'throw' of exception caught locally

Check warning on line 21 in src/apis/follow/deleteFollow.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Exception used for local control-flow

'throw' of exception caught locally

Check notice on line 5 in next.config.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Deprecated symbol used

Deprecated symbol used, consult docs for better alternative

Check notice on line 17 in public/mockServiceWorker.js

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Result of method call returning a promise is ignored

Promise returned from skipWaiting is ignored

Check notice on line 26 in src/hooks/serverStateHooks/useToggleFollow.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Result of method call returning a promise is ignored

Promise returned from invalidateQueries is ignored

Check notice on line 17 in src/app/providers/MSWProvider.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Result of method call returning a promise is ignored

Promise returned from initMsw is ignored

Check warning on line 61 in src/mocks/handlers.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Unused local symbol

Unused parameter request

Check warning on line 16 in src/mocks/handlers.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Unused local symbol

Unused parameter request

Check warning on line 26 in src/mocks/handlers.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Unused local symbol

Unused parameter request

Check warning on line 14 in src/app/auth/redirect/[provider]/page.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Unused local symbol

Unused constant isLoading

Check warning on line 24 in src/components/Card/ArtistProfileCard.tsx

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Unused local symbol

Unused constant artworkImage

Check warning on line 20 in src/hooks/serverStateHooks/useToggleFollow.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JS

Pointless statement or boolean expression

Can be simplified to isFollowing