[TASK-61] feat: 캐로젤 공통 컴포넌트 구현 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangWoo9734
added
feat
dahyeo-n
approved these changes
Dec 29, 2024
| interface DefaultCarouselPropsType<T> { | ||
| slides: T[]; | ||
| renderSlide: (card: T) => ReactNode; | ||
| spaceSize?: 'small' | 'medium' | 'large'; |
There was a problem hiding this comment.
아이콘 사이즈처럼 s, m, l 이렇게 통일하는 건 어떨까요?
There was a problem hiding this comment.
네! 좋습니다 수정하겠습니다_!
| spaceSize?: 'small' | 'medium' | 'large'; | ||
| } | ||
|
|
||
| const DefaultCarousel = <T,>({ |
There was a problem hiding this comment.
이부분은 다른 코드 참고하면서 작성해서 들어간 것 같습니다..!
조금 알아보니 큰 의미는 없고, JSX 문법과 제네릭이 유사항 형태를 가지니 두 가지를 구분하기 위해서 타입 하나만 받는 경우에 ,를 임의로 추가하기도 한다고 합니다..! 이부분은 수정하겠습니다!
There was a problem hiding this comment.
이게 VS 코드에서도 컴포넌트에 제네릭을 활용하려고 할 때는 <T> 작성하니 JSX로 인식해버리네요..
There was a problem hiding this comment.
generic in tsx로 검색했을 때 먼저 나오는 블로그입니다. tsx에서 제네릭을 쓸 때 대안으로 여러 방식을 사용할 수 있긴한데 현재 방식과 크게 다르지 않은 것 같네요..!
dahyeo-n
reviewed
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
📸 스크린샷