[TASK-49] style: 디자인 시스템 변경사항 반영 (국문/영문 폰트 설정, 공용 컴포넌트 기능 추가) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahyeo-n
added
chore
SangWoo9734
reviewed
Dec 24, 2024
| @@ -22,7 +22,7 @@ const EmailInput = ({ mode }: EmailInputProps) => { | |||
| setEmail(''); | |||
| }; | |||
|
|
|||
| const checkEmailStatus = (email: string) => { | |||
There was a problem hiding this comment.
혹시 이 부분은 제가 수정해도 괜찮을까요? validate 쪽이 많이 바뀔 것 같아서 제가 한 번에 수정하겠습니다!
src/components/Navbar/index.tsx
Outdated
| <div className='rounded-full bg-white w-8 h-8 flex-shrink-0'></div> | ||
| <button | ||
| className='button-m bg-main px-6 py-2 rounded-full text-white flex-shrink-0' | ||
| style={{ whiteSpace: 'nowrap' }} |
There was a problem hiding this comment.
여기만 인라인 스타일 적용하신 이유가 있을까요? whitespace-nowrap으로는 적용이 안되나요..?
There was a problem hiding this comment.
Layout 스타일 적용이 안 되는 부분이 있어서 이것저것 style 로 시도하다가 미처 삭제하는 걸 잊었네요 ㅠㅠ whitespace-nowrap 없어도 디자인한 UI대로 나와서 제거해서 push 했습니다!
SangWoo9734
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
className에font-sansCSS 클래스를 작성하면 적용되도록 추가FilterDropdown컴포넌트3-1) 아이콘 변경 (Dropup/Dropdown)
3-2) 선택된 옵션 강조 기능 추가
Pagination컴포넌트4-1) MoreHorizontal 아이콘 추가
4-2) 마지막 페이지 표시
4-3) 페이지 이동 시 버튼 위치 고정 및 페이지 그룹 전환 로직 구현
📸 스크린샷 (선택)
💬 전달사항