g2: re-add '.builder' #533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still needed after #534 is merged? |
|
Good question, probably not. We can hold off until #534 is done if that makes your life easier, then I can close it assuming it's resolved at that point. |
|
Not needed after #534. Only ip needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that our Spack fork doesn't have some of the builder/build_directory changes, so I should have made this change when I updated the g2 recipe from main Spack. It (and various other recipes) will probably need to change back with a future Spack update, but at the moment this is breaking the weekly builds on Acorn.