Adding missing values to test and reference value for comparison - #591
Open
rajichidamb wants to merge 2 commits into
Open
Adding missing values to test and reference value for comparison#591rajichidamb wants to merge 2 commits into
rajichidamb wants to merge 2 commits into
Conversation
rajichidamb
requested review from
fcvdb,
nicholasesposito,
shlyaeva and
sking112
July 31, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
build-group=https://github.com/JCSDA-internal/ufo/pull/4275
Adding check for missing values in the thickness predictor calculation. Adding a missing value in the data files and also changing the reference value in the file to match.
Also added the updates for ObsMetaDataPredictor https://github.com/JCSDA-internal/ufo/pull/3951
Issue(s) addressed
Resolves https://github.com/JCSDA-internal/ufo/issues/4090
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Manual Testing Instructions (optional)
If you would like your reviewers to manually build and test the change, please include
instructions on how the change should be built and tested. Also include a short
justification on why manual testing is necessary for this change.
Checklist