Adapt soca to ObsSpaceMaskHandler - #1251
Open
shlyaeva wants to merge 5 commits into
Open
Conversation
Adds the oops::ObsSpaceMaskHandler& parameter to ObsLocRossby::computeLocalization (iterator overload) and threads it through the (lon,lat) cache (useCache/doNotUseCache/ setCache) and the base ObsHorLocGC99::localizeLocalObs call, mirroring the ported ufo::ObsHorLocalization. Enables soca LETKF to build against the obsspace_mask_handler branch. test_soca_letkf, letkf3d, letkf_split_observer/solver all pass.
shlyaeva
marked this pull request as ready for review
July 14, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adaptation to https://github.com/JCSDA-internal/oops/pull/3174 which speeds up 3D LETKF.
build-group=https://github.com/JCSDA-internal/oops/pull/3340
build-group=https://github.com/JCSDA-internal/ioda/pull/1625
build-group=https://github.com/JCSDA-internal/ufo/pull/4242
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1527
build-group=https://github.com/JCSDA-internal/pyiri-jedi/pull/186
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1216
Checklist