Refresh diffusion dirac testrefs for oops::Diffusion iteration-bound fix - #1248
Merged
Conversation
Reference values shift from the median-dual control-volume area and geometry-aware iteration bound in oops#3319 (oops#3318). Testref-only; behavior unchanged.
travissluka
added
the
waiting for another PR
travissluka
added
the
waiting for another PR
3dvar_lowres uses the diffusion saber block for B; the geometry-aware iteration bound in oops#3319 shifts Jb past the 4e-4 tolerance. Testref-only.
travissluka
marked this pull request as ready for review
June 16, 2026 22:08
travissluka
requested review from
guillaumevernieres,
kbhargava,
ncrossette and
shlyaeva
June 29, 2026 16:43
Contributor
Author
|
ignore the CI, just mpas failure |
shlyaeva
approved these changes
Jun 29, 2026
guillaumevernieres
approved these changes
Jun 29, 2026
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Jul 1, 2026
…fix (#1212) ## Description Testref-only. mpas-jedi supplies its own `area` field, so the oops#3319 area fix leaves its operator unchanged; only the geometry-aware iteration bound shifts the horizontal iteration count (6→4 on the Voronoi mesh), slightly changing the diffused dirac fields. Reference values refreshed; no code change. ## Issue(s) addressed - JCSDA-internal/oops#3318 ## Dependencies This PR depends on: - JCSDA-internal/oops#3319 build-group=JCSDA-internal/oops#3319 build-group=JCSDA-internal/saber#1258 build-group=JCSDA-internal/ufo#4201 build-group=JCSDA-internal/soca#1248 ## Impact Updated references for `mpasjedi_dirac_diffusion_duplicated` and `mpasjedi_dirac_diffusion_univariate`. mpas-jedi behavior is unchanged. ## Manual Testing Instructions (optional) n/a ## Checklist - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [x] I have run the unit tests before creating the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testref-only. soca supplies its own
areafield, so the oops#3319 area fix does not change its operator; only the geometry-aware explicit-iteration bound in oops#3319 shifts the horizontal iteration count (496→462 at high res, 38→26 at low res), which slightly changes the diffused dirac fields. Reference values refreshed; no code change.Issue(s) addressed
Dependencies
This PR depends on:
build-group=https://github.com/JCSDA-internal/oops/pull/3319
build-group=https://github.com/JCSDA-internal/saber/pull/1258
build-group=https://github.com/JCSDA-internal/ufo/pull/4201
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1212
Impact
Updated references for
test_soca_dirac_diffusionandtest_soca_dirac_diffusion_lowres. soca behavior is unchanged.Manual Testing Instructions (optional)
n/a
Checklist