Skip to content

Ensemble postproc: Allow to not have zero-out variables in the list of increment variables #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shlyaeva merged 3 commits into from
May 27, 2026
Merged

Ensemble postproc: Allow to not have zero-out variables in the list of increment variables #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdd8a51
Ensemble postproc: Allow to not have zero-out variables in the list o…
shlyaeva May 18, 2026
55f7cea
Merge branch 'develop' into feature/ensrecenter_fix
shlyaeva May 21, 2026
df111e4
allow the State to not have all increment variables in +=
shlyaeva May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/mains/AnalysisPostproc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,13 @@ class AnalysisPostproc : public oops::Application {
if (incPostprocConfig.has("set increment variables to zero")) {
oops::Variables socaZeroIncrVar(incPostprocConfig, "set increment variables to zero");
if (!(socaZeroIncrVar <= incs.variables())) {
oops::Log::error() << "Variables to zero must be a subset of increment variables"
<< std::endl;
throw eckit::UserError("Invalid variables to zero", Here());
// Add variables that have to be set to zero to the increment variables,
// so that the increment can be updated
oops::Variables newvars = incs.variables();
newvars += socaZeroIncrVar;
for (size_t jj = 0; jj < incs.size(); ++jj) {
incs[jj].increment().updateFields(newvars);
}
Comment on lines 321 to +328
}
for (size_t jj = 0; jj < incs.size(); ++jj) {
// Note: this is soca::Increment specific method
Expand Down
5 changes: 5 additions & 0 deletions src/soca/State/State.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,11 @@ namespace soca {
const auto missing = util::missingValue<double>();
for (const auto & src : dx_interp->fieldSet()) {
const auto v_src = atlas::array::make_view<double, 2>(src);
if (!fieldSet_.has(src.name())) {
oops::Log::warning() << "State does not have variable " << src.name()
<< " from Increment, skipping." << std::endl;
continue;
Comment on lines +251 to +254
}
auto & dst = fieldSet_.field(src.name());
auto v_dst = atlas::array::make_view<double, 2>(dst);
for (size_t i = 0; i < src.shape(0); ++i) {
Expand Down
Loading