bug fix and code update to Magrigal TEC converter - #1800
Open
huishao-r wants to merge 3 commits into
Open
Conversation
huishao-r
commented
Jul 16, 2026
| locationKeyList.append((k, v)) | ||
| #HS: bug? | ||
| #HS for k, v in meta_data_types.items(): | ||
| #HS locationKeyList.append((k, v)) |
Collaborator
Author
There was a problem hiding this comment.
Need to check whether this is a bug
huishao-r
commented
Jul 16, 2026
|
|
||
| obs_data[("latitude", "MetaData")] = meta_data["piercePointLatitude"] | ||
| obs_data[("longitude", "MetaData")] = meta_data["piercePointLongitude"] | ||
| obs_data[("dateTime", "MetaData")] = meta_data["dateTime"] |
Collaborator
Author
There was a problem hiding this comment.
need to know what datetime is in the input file
haydenlj
marked this pull request as ready for review
July 20, 2026 19:46
Collaborator
|
@michael-a-herrera did you have a chance to look at this one pretty uncontroversial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Missing latitude and longitude are assigned to piecePointLaitude and piercePointLongitude.
Add missing datetime.
Also fix a bug which repeatedly adding localkeylist
Issue(s) addressed
Resolves #1801
Dependencies
None
Checklist