Skip to content

Allow forks to use presubmit CI by using "pull_request_target" workflow. - #1794

Merged
eap merged 3 commits into
developfrom
feature/pull-request-target
Jun 30, 2026
Merged

Allow forks to use presubmit CI by using "pull_request_target" workflow.#1794
eap merged 3 commits into
developfrom
feature/pull-request-target

Conversation

@eap

@eap eap commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Change the CI trigger to use on: pull_request_target:... instead of "on: pull_request:..." this means that all pull requests, including pull requests from forks, will run CI using the checked-in config from the target branch.

This change has been made to enable fork pull requests to test. The previous strategy only allowed tests from branches of this repository forks.

Issues:

This change unblocks #1792

Change the CI trigger to use `on: pull_request_target:...` instead of "on: pull_request:..." this means that all pull requests, including pull requests from forks, will run CI using the checked-in config from the target branch.

This change has been made to enable fork pull requests to test. The previous strategy only allowed tests from branches of this repository forks.
Remove 'master' and 'main' branches from pull request triggers.
Comment thread .github/workflows/start-jedi-ci.yaml
@eap
eap requested a review from weiwilliam June 30, 2026 18:53

@weiwilliam weiwilliam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @eap

@eap
eap merged commit e4c3f7d into develop Jun 30, 2026
@eap
eap deleted the feature/pull-request-target branch June 30, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants