Skip to content

Correct X position reading from TENET files - #1793

Open
haydenlj wants to merge 12 commits into
developfrom
bugfix/fix_electron_density_unit
Open

Correct X position reading from TENET files#1793
haydenlj wants to merge 12 commits into
developfrom
bugfix/fix_electron_density_unit

Conversation

@haydenlj

@haydenlj haydenlj commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

The converter IODA for TENET files was not including the decimal point indicated in the TENET format documentation when reading in the value of X position. Thus the X position of the ground station was off by several orders of magnitude. Correct the way this value is read

Issue(s) addressed

Resolves #1795

Dependencies

none

Impact

none

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@haydenlj haydenlj self-assigned this Jun 29, 2026
@BenjaminRuston

Copy link
Copy Markdown
Collaborator

@haydenlj you'll need to update the test/testoutput file too for the test_iodaconv_tec_groundbased unit test

@haydenlj haydenlj changed the title Change electron density unit to cm^-3 Correct X position reading from TENET files Jun 30, 2026
@haydenlj haydenlj added bug Something is not working NAVY United States Naval Research Lab space weather Space weather application labels Jun 30, 2026
Comment thread src/space_weather/gnss_tec_ground_based.py
@BenjaminRuston
BenjaminRuston self-requested a review July 22, 2026 23:24

@BenjaminRuston BenjaminRuston left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding that description for interpreting the format will be helpful

Comment thread src/space_weather/gnss_tec_ground_based.py Outdated
@BenjaminRuston

Copy link
Copy Markdown
Collaborator

@huishao-r or @michael-a-herrera this is good to go correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working NAVY United States Naval Research Lab space weather Space weather application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Correct groundbased TEC x position

3 participants