Fix function compute_scan_angle (QC flags), remove unused argument - #1780
Fix function compute_scan_angle (QC flags), remove unused argument#1780chengdang wants to merge 8 commits into
Conversation
chengdang
added
the
needs review
|
Have not tested it, needs to rebuild ioda |
@chengdang actually for these you don't technically need to rebuild, just copy the new def_jedi_utils.py into the $JEDI_BUILD directory,, the path is in I think lib/python/.... thanks for getting this in and for giving it the attention it needed |
|
@BenjaminRuston |
|
ok yes the hack is to obviously get on the branch and then you have to copy the so that's a shortcut to do a quick test |
|
Thank you @BenjaminRuston 
I think it is working as expected, but more tests with other sensors are probably needed. |
| # do we need a missing here | ||
| ratio = np.empty_like(sensor_altitude) | ||
| # Initialize output with missing values | ||
| scanang = np.full_like(sensor_altitude, np.nan, dtype=float) |
There was a problem hiding this comment.
@chengdang just one small change, this utility also tried to standardize the int, float and long missing values put into the files... they are globals up at the top
update to float missing from np.nan
| # do we need a missing here | ||
| ratio = np.empty_like(sensor_altitude) | ||
| # Initialize output with missing values | ||
| scanang = np.full_like(sensor_altitude, float_missing_value, dtype=float) |
There was a problem hiding this comment.
Test are failing, so is the value supposed to be double missing value?
DIFFER : VARIABLE : sensorViewAngle : TYPE : DOUBLE <> FLOAT
DIFFER : TYPES : ATTRIBUTE : _FillValue : VARIABLE : sensorViewAngle : DOUBLE <> FLOAT
|
ok @rajichidamb picked up your other changes and yes got some failures, switching to double to see if the failures change as this may fix those and cause other errors now elsewhere think we have a situation where some converters used float and other double for the missing value |
| # do we need a missing here | ||
| ratio = np.empty_like(sensor_altitude) | ||
| # Initialize output with missing values | ||
| scanang = np.full_like(sensor_altitude, double_missing_value, dtype=float) |
There was a problem hiding this comment.
Setting dtype=float but using double_missing_value? Other python scripts fill the array with 'float32'
sensor_altitude,
np.array(f['GeolocationAndFlags']['earth_inc_ang'], dtype='float32'),
4 participants
Description
This PR fixes
compute_scan_angleby:compute_scan_angleIssue(s) addressed
Resolves issue #1775
Dependencies
None
Impact
None
Checklist