-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump axios from 0.21.4 to 1.6.2 #247
Conversation
@mprew97 Are you planning on merging my PRs? Just trying to plan if I'm waiting on this to be merged or if I should patch your package. |
Hey @ptessier, apologies for the delay on this. I actually was working on bundling a whole bunch of dependency issues and it's taken me longer than expected to get them tested and deployed. For the sake of time, I will test this PR first thing when I'm back this Tuesday and merge/deploy this. |
Thanks for the heads up. If you have some time, I also have two other PRs with small changes we patched in our repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved
@ptessier working on cutting the release for this and your other PRs. Thanks for your patience here. Will hopefully have it released by EOD today or tomorrow. |
@mprew97 Wow amazing, thanks! |
@ptessier changes are now packaged and released in |
@mprew97 Seems like the auth is failing after bumping to |
Seems like it might be related to the axios version that is bundled in the library. |
@ptessier I'm not seeing any immediate issues with our own auth after bumping. Please open a separate issue with reproducibles if you are still experiencing this. |
Description
Bump axios to resolve GHSA-wf5p-g6vw-rhxx
Relied on unit tests to make sure it works.