SDK-199 Auth Retry policy completely bypassed #987
+93
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 69.26% 69.41% +0.15%
==========================================
Files 109 109
Lines 8917 8926 +9
==========================================
+ Hits 6176 6196 +20
+ Misses 2741 2730 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ayyanchira
reviewed
Dec 16, 2025
| let timeIntervalToRefresh = TimeInterval(expirationDate) - dateProvider.currentDate.timeIntervalSince1970 - expirationRefreshPeriod | ||
| if timeIntervalToRefresh > 0 { | ||
| scheduleAuthTokenRefreshTimer(interval: timeIntervalToRefresh, isScheduledRefresh: true, successCallback: onSuccess) | ||
| resetRetryCount() |
Member
There was a problem hiding this comment.
Schedule wont necessarily guarantees successful retrieval of token. Should we reset the count here?
Member
Author
There was a problem hiding this comment.
My understanding is that since the schedule is fired, we can reset the retries. regardless of its success.
Comment on lines
+70
to
+79
| if pauseAuthRetry { | ||
| return true | ||
| } | ||
|
|
||
| // Scheduled refresh should never bypass retry safety limits. | ||
| if isInScheduledRefreshCallback { | ||
| return retryCount >= authRetryPolicy.maxRetry | ||
| } | ||
|
|
||
| return retryCount >= authRetryPolicy.maxRetry && !shouldIgnoreRetryPolicy |
Member
There was a problem hiding this comment.
This looks simplified and better.
Comment on lines
+229
to
+232
| if self.localStorage.email != nil || self.localStorage.userId != nil { | ||
| self.isInScheduledRefreshCallback = isScheduledRefresh | ||
| self.requestNewAuthToken(hasFailedPriorAuth: false, onSuccess: successCallback, shouldIgnoreRetryPolicy: isScheduledRefresh) | ||
| self.isInScheduledRefreshCallback = false |
Member
There was a problem hiding this comment.
This part should be well tested manually as well
Member
Author
There was a problem hiding this comment.
I'm leaning on these tests to cover this part:
- Refresh is queued and callback fires (scheduled refresh path hits the timer closure and requests a token)
- Skip refresh when there’s no email and no userId
- Scheduled refresh respects retry limits (this is specifically exercising isInScheduledRefreshCallback + shouldPauseRetry logic invoked inside the timer closure when isScheduledRefresh == true)
- Pausing retries blocks the refresh (this hits shouldSkipTokenRefresh before scheduling the timer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
Fixes auth retry for expired JWT refresh: scheduled token refresh no longer bypasses
pauseAuthRetriesorauthRetryPolicy.maxRetry, preventing runaway/infiniteonAuthTokenRequestedloops.Added unit tests to lock pause + maxRetry behavior on scheduled refresh, and reset retry count after a successful refresh is queued.